Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2473)

Unified Diff: runtime/observatory/lib/src/elements/script_view.html

Issue 1123143002: Make script-insets obey their bounds, and other padding tweaks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/script_view.html
diff --git a/runtime/observatory/lib/src/elements/script_view.html b/runtime/observatory/lib/src/elements/script_view.html
index a4aa02ddc97d394aaa5657796ee0651338822454..1fd151049b21d8160d34b417c17b95f1ea31905b 100644
--- a/runtime/observatory/lib/src/elements/script_view.html
+++ b/runtime/observatory/lib/src/elements/script_view.html
@@ -17,18 +17,19 @@
<nav-refresh callback="{{ refresh }}"></nav-refresh>
</nav-bar>
- <template if="{{ app.locationManager.internalArguments['pos'] == null }}">
- <script-inset id="scriptInset" script="{{ script }}">
- <h1>script {{ script.name }}</h1>
- </script-inset>
- </template>
+ <div class="content-centered-big">
+ <h1>script {{ script.name }}</h1>
+ <hr>
+ <template if="{{ app.locationManager.internalArguments['pos'] == null }}">
+ <script-inset id="scriptInset" script="{{ script }}"></script-inset>
turnidge 2015/05/06 07:14:42 Could we make script-inset accept a null for curre
rmacnak 2015/05/06 17:10:33 Hm, it already does. Dropped the template-if.
+ </template>
- <template if="{{ app.locationManager.internalArguments['pos'] != null }}">
- <script-inset id="scriptInset" script="{{ script }}"
- currentPos="{{ app.locationManager.internalArguments['pos'] | parseInt }}">
- <h1>script {{ script.name }}</h1>
- </script-inset>
- </template>
+ <template if="{{ app.locationManager.internalArguments['pos'] != null }}">
+ <script-inset id="scriptInset" script="{{ script }}"
+ currentPos="{{ app.locationManager.internalArguments['pos'] | parseInt }}">
+ </script-inset>
+ </template>
+ </div>
<view-footer></view-footer>
</template>

Powered by Google App Engine
This is Rietveld 408576698