Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Unified Diff: pkg/unittest/mock.dart

Issue 11231074: Change signature of noSuchMethod to take an InvocationMirror. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: One more test expectation Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/pkg.status ('k') | runtime/lib/invocation_mirror_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/mock.dart
diff --git a/pkg/unittest/mock.dart b/pkg/unittest/mock.dart
index f743d330473f095584375509b7cd92109c25ff11..f0f5765f626e7bea01e9006841fe215957af73a1 100644
--- a/pkg/unittest/mock.dart
+++ b/pkg/unittest/mock.dart
@@ -1276,10 +1276,17 @@ class Mock {
* return value. If we find no [Behavior] to apply an exception is
* thrown.
*/
- noSuchMethod(String method, List args) {
- if (method.startsWith('get:')) {
- method = 'get ${method.substring(4)}';
+ noSuchMethod(InvocationMirror invocation) {
+ String method = invocation.memberName;
+ // Remove this when InvocationMirror works correctly.
+ if (method.startsWith("get:")) method = method.substring(4);
+
+ if (invocation.isGetter) {
+ method = 'get $method';
}
+ List args = invocation.positionalArguments;
+ // TODO: Handle named arguments too.
+
bool matchedMethodName = false;
MatchState matchState = new MatchState();
for (String k in _behaviors.keys) {
« no previous file with comments | « pkg/pkg.status ('k') | runtime/lib/invocation_mirror_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698