lib/compiler/implementation/ssa/codegen.dart - Issue 11231074: Change signature of noSuchMethod to take an InvocationMirror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 11231074: Change signature of noSuchMethod to take an InvocationMirror. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix dart2js, update tests, expectations. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/lib/js_helper.dart ('K') | « lib/compiler/implementation/lib/js_helper.dart ('k') | lib/compiler/implementation/universe/universe.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/ssa/codegen.dart

diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart

index fdf877a754a08a2d1488902d9dd53081e471ac12..4fc34702661da2853a1082e9a92b781563295cf7 100644

--- a/lib/compiler/implementation/ssa/codegen.dart

+++ b/lib/compiler/implementation/ssa/codegen.dart

@@ -1515,6 +1515,13 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

Selector defaultSelector) {

// TODO(4434): For private members we need to use the untyped selector.

if (defaultSelector.name.isPrivate()) return defaultSelector;

+ // If [noSuchMethod] has been overridden and [InvocationMirror.invokeOn]

Johnni Winther 2012/10/29 12:05:55 Change to 'If [JSInvocationMirror.invokeOn] has be

Lasse Reichstein Nielsen 2012/10/30 10:03:31 Done.

+ // has been called we must not create a typed selector based on the receiver

+ // type.

+ if (node.element == null && // Invocation is not exact.

+ backend.compiler.enabledInvokeOn) {

+ return defaultSelector;

+ }

HType receiverHType = types[node.inputs[0]];

DartType receiverType = receiverHType.computeType(compiler);

if (receiverType != null) {