base/metrics/histogram_base.h - Issue 11231025: Histogram argument related change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_base.h

Issue 11231025: Histogram argument related change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_base.h

diff --git a/base/metrics/histogram_base.h b/base/metrics/histogram_base.h

index 211606a9898b7bad263643bb092878fe8eb4c93e..8c78a79e5ab33835b47ea03440704383e12a1ff9 100644

--- a/base/metrics/histogram_base.h

+++ b/base/metrics/histogram_base.h

@@ -51,8 +51,14 @@ class BASE_EXPORT HistogramBase {

void SetFlags(int32 flags);

void ClearFlags(int32 flags);

+ virtual bool HasConstructionArguments(Sample minimum,

Ilya Sherman 2012/10/24 00:30:08 nit: Please add a comment describing this method.

kaiwang 2012/10/24 03:43:28 Done.

+ Sample maximum,

+ size_t bucket_count) const = 0;

virtual void Add(Sample value) = 0;

+ // Snapshot the current complete set of sample data.

+ // Override with atomic/locked snapshot if needed.

virtual scoped_ptr<HistogramSamples> SnapshotSamples() const = 0;

// The following methods provide graphical histogram displays.