Remove ::create factory functions from objects created via WebCompositorSupport

Remove ::create factory functions from objects created via WebCompositorSupport

These are uncalled and don't actually work at all in the component build.
Leaving them around is just confusing. Code that wants to instantiate these
types can use the WebCompositorSupport interface or directly construct
the Impls.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167188

[jamesr, 2012-10-19 21:56:08]

After this lands + rolls I'll delete the ::create() declarations from WebKit.

[enne (OOO), 2012-10-22 19:24:09]

lgtm

[commit-bot: I haz the power, 2012-10-22 19:39:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11231017/1

[commit-bot: I haz the power, 2012-10-22 19:53:49]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[jamesr, 2012-10-23 03:15:40]

+cc Alex (for review) and Yaron (for OWNERS).

There were a few calls here hidden in android code which 'worked' since android
doesn't have the component build.  I've moved them to use WebCompositorSupport. 
Alex plans to port all these over to using something like
WebCompositorSupportImpl directly, but this seems like a step in the right
direction at least.

[aelias_OOO_until_Jul13, 2012-10-23 03:22:55]

http://codereview.chromium.org/11231017/diff/11017/chrome/browser/android/tab...
File chrome/browser/android/tab_base_android_impl.cc (right):

http://codereview.chromium.org/11231017/diff/11017/chrome/browser/android/tab...
chrome/browser/android/tab_base_android_impl.cc:65:
WebKit::Platform::current()->compositorSupport()->createLayer);
This won't compile, missing parens after createLayer.

lgtm otherwise.

[Jay Civelli, 2012-10-23 19:55:19]

LGTM for chrome/android

[Yaron, 2012-10-23 20:06:44]

lgtm (if Jay's wasn't enough)

[commit-bot: I haz the power, 2012-10-23 21:29:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11231017/10018

[commit-bot: I haz the power, 2012-10-23 21:43:59]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-12 03:05:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11231017/21001

[commit-bot: I haz the power, 2012-11-12 03:05:25]

Failed to apply patch for chrome/android/testshell/tab_manager.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/android/testshell/tab_manager.cc
  Hunk #1 succeeded at 14 with fuzz 2 (offset -1 lines).
  Hunk #2 FAILED at 74.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/android/testshell/tab_manager.cc.rej

Patch:       chrome/android/testshell/tab_manager.cc
Index: chrome/android/testshell/tab_manager.cc
diff --git a/chrome/android/testshell/tab_manager.cc
b/chrome/android/testshell/tab_manager.cc
index
fc379dd155aeea242fde5138d8128766cb5b16ef..5c5465c50f82ce1fff9c6d1bda1257d6285535f7
100644
--- a/chrome/android/testshell/tab_manager.cc
+++ b/chrome/android/testshell/tab_manager.cc
@@ -15,6 +15,8 @@
 #include "content/public/browser/android/compositor.h"
 #include "content/public/browser/android/draw_delegate.h"
 #include "jni/TabManager_jni.h"
+#include "third_party/WebKit/Source/Platform/chromium/public/Platform.h"
+#include
"third_party/WebKit/Source/Platform/chromium/public/WebCompositorSupport.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebLayer.h"
 
 #include <android/native_window_jni.h>
@@ -72,7 +74,8 @@ static void Init(JNIEnv* env, jclass clazz, jobject obj) {
     g_global_state.Get().compositor.reset(content::Compositor::Create(
         &g_global_state.Get().client));
     DCHECK(!g_global_state.Get().root_layer.get());
-    g_global_state.Get().root_layer.reset(WebKit::WebLayer::create());
+    g_global_state.Get().root_layer.reset(
+        WebKit::Platform::current()->compositorSupport()->createLayer());
   }
 }

[jamesr, 2012-11-12 05:57:50]

@sky - could you OWNERS review for content/browser/renderer_host/ and CQ ?
thanks!

[sky, 2012-11-12 15:01:24]

LGTM

[commit-bot: I haz the power, 2012-11-12 15:01:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11231017/29001

[commit-bot: I haz the power, 2012-11-12 16:24:41]

Change committed as 167188