Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: src/platform-win32.cc

Issue 11231002: Perform CPU sampling by CPU sampling thread only iff processing thread is not running. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: fixed crash in tests due to absent sampler Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform-solaris.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform-win32.cc
diff --git a/src/platform-win32.cc b/src/platform-win32.cc
index 5e4dcf5850eb7ee451cd3c80cdbace39b9e9cc97..27433b25afd7a47d214efec550a2ea53e33fb373 100644
--- a/src/platform-win32.cc
+++ b/src/platform-win32.cc
@@ -2044,8 +2044,9 @@ class SamplerThread : public Thread {
CONTEXT context;
memset(&context, 0, sizeof(context));
+ TickSample sample_obj;
TickSample* sample = CpuProfiler::StartTickSampleEvent(sampler->isolate());
- if (sample == NULL) return;
+ if (sample == NULL) sample = &sample_obj;
static const DWORD kSuspendFailed = static_cast<DWORD>(-1);
if (SuspendThread(profiled_thread) == kSuspendFailed) return;
@@ -2139,4 +2140,12 @@ void Sampler::Stop() {
}
+void Sampler::StartSampling() {
+}
+
+
+void Sampler::StopSampling() {
+}
+
+
} } // namespace v8::internal
« no previous file with comments | « src/platform-solaris.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698