Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: src/platform-macos.cc

Issue 11231002: Perform CPU sampling by CPU sampling thread only iff processing thread is not running. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 801 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 sampler_thread->SampleContext(sampler); 812 sampler_thread->SampleContext(sampler);
813 } 813 }
814 814
815 static void DoRuntimeProfile(Sampler* sampler, void* ignored) { 815 static void DoRuntimeProfile(Sampler* sampler, void* ignored) {
816 if (!sampler->isolate()->IsInitialized()) return; 816 if (!sampler->isolate()->IsInitialized()) return;
817 sampler->isolate()->runtime_profiler()->NotifyTick(); 817 sampler->isolate()->runtime_profiler()->NotifyTick();
818 } 818 }
819 819
820 void SampleContext(Sampler* sampler) { 820 void SampleContext(Sampler* sampler) {
821 thread_act_t profiled_thread = sampler->platform_data()->profiled_thread(); 821 thread_act_t profiled_thread = sampler->platform_data()->profiled_thread();
822 TickSample* sample = CpuProfiler::StartTickSampleEvent(sampler->isolate()); 822 TickSample sample_obj;
823 if (sample == NULL) return; 823 TickSample* sample = CpuProfiler::StartTickSampleEvent(isolate);
824 if (sample == NULL) sample = &sample_obj;
825
824 826
825 if (KERN_SUCCESS != thread_suspend(profiled_thread)) return; 827 if (KERN_SUCCESS != thread_suspend(profiled_thread)) return;
826 828
827 #if V8_HOST_ARCH_X64 829 #if V8_HOST_ARCH_X64
828 thread_state_flavor_t flavor = x86_THREAD_STATE64; 830 thread_state_flavor_t flavor = x86_THREAD_STATE64;
829 x86_thread_state64_t state; 831 x86_thread_state64_t state;
830 mach_msg_type_number_t count = x86_THREAD_STATE64_COUNT; 832 mach_msg_type_number_t count = x86_THREAD_STATE64_COUNT;
831 #if __DARWIN_UNIX03 833 #if __DARWIN_UNIX03
832 #define REGISTER_FIELD(name) __r ## name 834 #define REGISTER_FIELD(name) __r ## name
833 #else 835 #else
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
922 } 924 }
923 925
924 926
925 void Sampler::Stop() { 927 void Sampler::Stop() {
926 ASSERT(IsActive()); 928 ASSERT(IsActive());
927 SamplerThread::RemoveActiveSampler(this); 929 SamplerThread::RemoveActiveSampler(this);
928 SetActive(false); 930 SetActive(false);
929 } 931 }
930 932
931 933
934 void Sampler::StartSampling() {
935 }
936
937
938 void Sampler::StopSampling() {
939 }
940
941
932 } } // namespace v8::internal 942 } } // namespace v8::internal
OLDNEW
« src/platform-cygwin.cc ('K') | « src/platform-linux.cc ('k') | src/platform-nullos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698