device/usb/usb_device_filter.cc - Issue 1123093003: Add a manifest property declaring USB printers supported by an app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/usb_device_filter.cc

Issue 1123093003: Add a manifest property declaring USB printers supported by an app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix leak of Value-encoded device filter in tests. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/usb/usb_device_filter.h ('k') | extensions/common/api/_manifest_features.json » ('j') | extensions/common/api/extensions_manifest_types.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/usb/usb_device_filter.cc

diff --git a/device/usb/usb_device_filter.cc b/device/usb/usb_device_filter.cc

index 970bbd041b17c2dc05d1f39f3278dda50d09e8aa..b52a4a3edc9af7af8603b80288d8181ce942441a 100644

--- a/device/usb/usb_device_filter.cc

+++ b/device/usb/usb_device_filter.cc

@@ -96,7 +96,7 @@ bool UsbDeviceFilter::Matches(scoped_refptr<UsbDevice> device) const {

return true;

}

-base::Value* UsbDeviceFilter::ToValue() const {

+scoped_ptr<base::Value> UsbDeviceFilter::ToValue() const {

scoped_ptr<base::DictionaryValue> obj(new base::DictionaryValue());

if (vendor_id_set_) {

@@ -116,7 +116,7 @@ base::Value* UsbDeviceFilter::ToValue() const {

}

- return obj.release();

+ return obj.Pass();

}

// static

« no previous file with comments | « device/usb/usb_device_filter.h ('k') | extensions/common/api/_manifest_features.json » ('j') | extensions/common/api/extensions_manifest_types.json » ('J')