Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1123093003: Add a manifest property declaring USB printers supported by an app. (Closed)

Created:
5 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a manifest property declaring USB printers supported by an app. This new manifest property "usb_printers" declares a set of USB device filters matching the printers supported by an app. This will be used by the printerProvider API to allow the user to select a printer that can be supported by the app and in so doing grant the app permission to connect to the printer. BUG=468955 Committed: https://crrev.com/1f30d4f3bd5c6058d32984de32e57db8205daaa5 Cr-Commit-Position: refs/heads/master@{#328845}

Patch Set 1 : #

Patch Set 2 : Fixed documentation. #

Patch Set 3 : Fix leak of Value-encoded device filter in tests. #

Total comments: 2

Patch Set 4 : Fix interfaceProtocol documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -3 lines) Patch
A chrome/common/extensions/docs/templates/articles/manifest/usb_printers.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/manifest.json View 1 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/manifest/usb_printers.html View 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/usb_device_filter.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M device/usb/usb_device_filter.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/api/_manifest_features.json View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/api/extensions_manifest_types.json View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A extensions/common/api/printer_provider/usb_printer_manifest_data.h View 1 chunk +43 lines, -0 lines 0 comments Download
A extensions/common/api/printer_provider/usb_printer_manifest_data.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A extensions/common/api/printer_provider/usb_printer_manifest_handler.h View 1 chunk +26 lines, -0 lines 0 comments Download
A extensions/common/api/printer_provider/usb_printer_manifest_handler.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A extensions/common/api/printer_provider/usb_printer_manifest_unittest.cc View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
M extensions/common/common_manifest_handlers.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/common/manifest_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/manifest_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/extensions_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A extensions/test/data/manifest_tests/usb_printers_filters.json View 1 chunk +21 lines, -0 lines 0 comments Download
A extensions/test/data/manifest_tests/usb_printers_invalid_filter.json View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Reilly Grant (use Gerrit)
Please take a look. The trybots are going to fail until https://codereview.chromium.org/1128523003/ lands.
5 years, 7 months ago (2015-05-05 22:52:59 UTC) #2
asargent_no_longer_on_chrome
One high-level question: would we ever want to allow developers to specify not just include ...
5 years, 7 months ago (2015-05-07 18:13:44 UTC) #4
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1123093003/diff/60001/extensions/common/api/extensions_manifest_types.json File extensions/common/api/extensions_manifest_types.json (right): https://codereview.chromium.org/1123093003/diff/60001/extensions/common/api/extensions_manifest_types.json#newcode199 extensions/common/api/extensions_manifest_types.json:199: "optional": true On 2015/05/07 18:13:43, Antony Sargent wrote: > ...
5 years, 7 months ago (2015-05-07 20:33:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123093003/80001
5 years, 7 months ago (2015-05-07 20:39:06 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 7 months ago (2015-05-07 21:48:24 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 21:49:24 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1f30d4f3bd5c6058d32984de32e57db8205daaa5
Cr-Commit-Position: refs/heads/master@{#328845}

Powered by Google App Engine
This is Rietveld 408576698