IDL compiler: [Constructor] overloading

Source/bindings/templates/methods.cpp

 {##############################################################################}
 {% macro generate_method(method, world_suffix) %}
 {% filter conditional(method.conditional_string) %}
 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     {% if method.is_raises_exception or method.is_check_security_for_frame or
           method.name in ['addEventListener', 'removeEventListener'] %}
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.name}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
     {% endif %}
     {% if method.name in ['addEventListener', 'removeEventListener'] %}
@@ skipping 263 matching lines @@
     v8SetReturnValue(info, privateTemplate->GetFunction());
 }
 
 static void {{method.name}}OriginSafeMethodGetterCallback{{world_suffix}}(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
     {{cpp_class}}V8Internal::{{method.name}}OriginSafeMethodGetter{{world_suffix}}(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
 }
 {% endmacro %}
+
+
+{##############################################################################}
+{% macro constructor_callback(constructor) %}
+static void constructor{{constructor.overload_index}}(const v8::FunctionCallbackInfo<v8::Value>& info)
+{
+    {% if interface_length and not constructor.overload_index %}
+    {# FIXME: remove this UNLIKELY: constructors are heavy, so no difference. #}
+    if (UNLIKELY(info.Length() < {{interface_length}})) {
+        throwTypeError(ExceptionMessages::failedToExecute("Constructor", "{{interface_name}}", ExceptionMessages::notEnoughArguments({{interface_length}}, info.Length())), info.GetIsolate());

[haraken, 2013/12/13 10:23:31]

You can use the throw_type_error macro here, or you can remove the
throw_type_error macro.

[Nils Barth (inactive), 2013/12/16 03:15:57]

Fixed; used macro consistently.

+        return;
+    }
+    {% endif %}
+    {% if is_constructor_raises_exception %}
+    ExceptionState exceptionState(ExceptionState::ConstructionContext, "{{interface_name}}", info.Holder(), info.GetIsolate());
+    {% endif %}
+    {% for argument in constructor.arguments %}
+    {{generate_argument(constructor, argument) | indent}}
+    {% endfor %}
+    {% if is_constructor_call_with_execution_context %}
+    ExecutionContext* context = getExecutionContext();
+    {% endif %}
+    {% if is_constructor_call_with_document %}

[haraken, 2013/12/13 10:23:31]

I hope you replace [CallWith=Document] with [CallWith=ExecutionContext] in the
near future.

[Nils Barth (inactive), 2013/12/16 03:15:57]

Got it; will do after finish other constructors ([CustomConstructor] and
[NamedConstructor])!

+    Document& document = *toDocument(getExecutionContext());
+    {% endif %}
+    RefPtr<{{cpp_class}}> impl = {{cpp_class}}::create({{constructor.argument_list | join(', ')}});
+    v8::Handle<v8::Object> wrapper = info.Holder();
+    {% if is_constructor_raises_exception %}
+    if (exceptionState.throwIfNeeded())
+        return;
+    {% endif %}
+
+    V8DOMWrapper::associateObjectWithWrapper<{{v8_class}}>(impl.release(), &{{v8_class}}::wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Dependent);

[haraken, 2013/12/13 10:23:31]

Question: I wonder why we always specify 'Dependent'. We should specify
'Dependent' only for dependent objects (these objects have [DependentLifeTime]
or inherit from ActiveDOMObject) and specify 'Independent' for other objects.
Probably this is a bug of the IDL compiler.

[Nils Barth (inactive), 2013/12/16 03:15:57]

Added a FIXME to that effect!

+    v8SetReturnValue(info, wrapper);
+}
+{% endmacro %}