IDL compiler: [Constructor] overloading

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 2683 matching lines @@
     }
     return ($parameterCheckString, $paramIndex, %replacements);
 }
 
 sub GenerateOverloadedConstructorCallback
 {
     my $interface = shift;
     my $interfaceName = $interface->name;
     my $implClassName = GetImplName($interface);
 
-    my $hasExceptionState = 0;
-    my $header = "";
-    $header .= <<END;
+    my $code .= <<END;
 static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
 END
-    my $code = "";
     my $leastNumMandatoryParams = 255;
     foreach my $constructor (@{$interface->constructors}) {
         my $name = "constructor" . $constructor->overloadedIndex;
         my ($numMandatoryParams, $parametersCheck) = GenerateFunctionParametersCheck($constructor);
         $leastNumMandatoryParams = $numMandatoryParams if ($numMandatoryParams < $leastNumMandatoryParams);
         $code .= "    if ($parametersCheck) {\n";
         $code .= "        ${implClassName}V8Internal::${name}(info);\n";
         $code .= "        return;\n";
         $code .= "    }\n";
     }
+    AddToImplIncludes("bindings/v8/ExceptionMessages.h");  # FIXME: remove when rebase (after https://codereview.chromium.org/110423004/ lands)
     if ($leastNumMandatoryParams >= 1) {
-        if (!$hasExceptionState) {
-            AddToImplIncludes("bindings/v8/ExceptionMessages.h");
-            $header .= "    ExceptionState exceptionState(ExceptionState::ConstructionContext, \"${interfaceName}\", info.Holder(), info.GetIsolate());\n";
-            $hasExceptionState = 1;
-        }
-        $code .= "    if (UNLIKELY(info.Length() < $leastNumMandatoryParams)) {\n";
-        $code .= "        exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments($leastNumMandatoryParams, info.Length()));\n";
-        $code .= "        exceptionState.throwIfNeeded();\n";
-        $code .= "        return;\n";
-        $code .= "    }\n";
+        $code .= <<END;
+    ExceptionState exceptionState(ExceptionState::ConstructionContext, \"${interfaceName}\", info.Holder(), info.GetIsolate());
+    if (UNLIKELY(info.Length() < $leastNumMandatoryParams)) {
+        exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments($leastNumMandatoryParams, info.Length()));
+        exceptionState.throwIfNeeded();
+        return;
     }
-    if ($hasExceptionState) {
-        $code .= <<END;
     exceptionState.throwTypeError(\"No matching constructor signature.\");
     exceptionState.throwIfNeeded();
 END
     } else {
-        AddToImplIncludes("bindings/v8/ExceptionMessages.h");
         $code .= <<END;
     throwTypeError(ExceptionMessages::failedToConstruct(\"${interfaceName}\", \"No matching constructor signature.\"), info.GetIsolate());
 END
     }
     $code .= "}\n\n";
-    $implementation{nameSpaceInternal}->add($header . $code);
+    $implementation{nameSpaceInternal}->add($code);
 }
 
 sub GenerateSingleConstructorCallback
 {
     my $interface = shift;
     my $function = shift;
 
     my $interfaceName = $interface->name;
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
@@ skipping 3595 matching lines @@
 
     return 1 if ExtendedAttributeContains($interface->extendedAttributes->{"Custom"}, "ToV8");
     return 1 if ExtendedAttributeContains($interface->extendedAttributes->{"Custom"}, "Wrap");
     return 1 if $interface->extendedAttributes->{"SpecialWrapFor"};
     return 1 if InheritsInterface($interface, "Document");
 
     return 0;
 }
 
 1;