Issue 11230057: Move pexpect try-except to pexpect wrapper file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11230057: Move pexpect try-except to pexpect wrapper file. (Closed)

Created:
8 years, 2 months ago by tonyg

Modified:
8 years, 2 months ago

Reviewers:
bulach

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move pexpect try-except to pexpect wrapper file. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163565

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	build/android/pylib/android_commands.py	View		1 chunk	+1 line, -6 lines	0 comments	Download
	M	build/android/pylib/pexpect.py	View		1 chunk	+6 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, thanks tony! nit below: https://codereview.chromium.org/11230057/diff/1/build/android/pylib/pexpect.py File build/android/pylib/pexpect.py (right): https://codereview.chromium.org/11230057/diff/1/build/android/pylib/pexpect.py#newcode21 build/android/pylib/pexpect.py:21: pexpect = None nit: ...

8 years, 2 months ago (2012-10-23 15:28:25 UTC) #2

tonyg

8 years, 2 months ago (2012-10-23 15:31:41 UTC) #3

https://codereview.chromium.org/11230057/diff/1/build/android/pylib/pexpect.py
File build/android/pylib/pexpect.py (right):

https://codereview.chromium.org/11230057/diff/1/build/android/pylib/pexpect.p...
build/android/pylib/pexpect.py:21: pexpect = None
On 2012/10/23 15:28:25, bulach wrote:
> nit: I guess "pass" would be better..

Done.

Expand Messages | Collapse Messages