Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: tests/language/positional_parameters_type_test.dart

Issue 11230041: Remove explicit --reject_named_argument_as_positional flag in language tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/named_parameters_type_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/positional_parameters_type_test.dart
===================================================================
--- tests/language/positional_parameters_type_test.dart (revision 13909)
+++ tests/language/positional_parameters_type_test.dart (working copy)
@@ -1,14 +1,10 @@
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// VMOptions=--enable_type_checks --no_reject_named_argument_as_positional
+// VMOptions=--enable_type_checks
//
-// Dart test program for testing optional parameters in type tests.
+// Dart test program for testing optional positional parameters in type tests.
-// TODO(regis): The expected signatures below will change once we run this test
-// with --reject_named_argument_as_positional which is still too early to do at
-// this time.
-
class NamedParametersTypeTest {
static int testMain() {
int result = 0;
@@ -27,27 +23,25 @@
acceptFunNumOptBool(funNum); // No static type warning.
} on TypeError catch (error) {
result += 1;
- Expect.stringEquals("(num, [b: bool]) => void", error.dstType);
+ Expect.stringEquals("(num, [bool]) => void", error.dstType);
Expect.stringEquals("(num) => void", error.srcType);
}
try {
acceptFunNumOptBool(funNumBool); /// static type warning
} on TypeError catch (error) {
result += 10;
- Expect.stringEquals("(num, [b: bool]) => void", error.dstType);
+ Expect.stringEquals("(num, [bool]) => void", error.dstType);
Expect.stringEquals("(num, bool) => void", error.srcType);
}
try {
- acceptFunNumOptBool(funNumOptBoolX); /// static type warning
+ acceptFunNumOptBool(funNumOptBoolX); // No static type warning.
} on TypeError catch (error) {
result += 100;
- Expect.stringEquals("(num, [b: bool]) => void", error.dstType);
- Expect.stringEquals("(num, [x: bool]) => void", error.srcType);
}
return result;
}
}
main() {
- Expect.equals(111, NamedParametersTypeTest.testMain());
+ Expect.equals(11, NamedParametersTypeTest.testMain());
}
« no previous file with comments | « tests/language/named_parameters_type_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698