Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Side by Side Diff: runtime/vm/intermediate_language.cc

Issue 11230034: Fix super ==: Test first for null before call inf super ==. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/intermediate_language.h" 5 #include "vm/intermediate_language.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/dart_entry.h" 8 #include "vm/dart_entry.h"
9 #include "vm/flow_graph_allocator.h" 9 #include "vm/flow_graph_allocator.h"
10 #include "vm/flow_graph_builder.h" 10 #include "vm/flow_graph_builder.h"
(...skipping 1834 matching lines...) Expand 10 before | Expand all | Expand 10 after
1845 } 1845 }
1846 } 1846 }
1847 1847
1848 1848
1849 LocationSummary* StaticCallInstr::MakeLocationSummary() const { 1849 LocationSummary* StaticCallInstr::MakeLocationSummary() const {
1850 return MakeCallSummary(); 1850 return MakeCallSummary();
1851 } 1851 }
1852 1852
1853 1853
1854 void StaticCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 1854 void StaticCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
1855 Label skip_call;
1856 const String& equality_name = String::Handle(Symbols::New("=="));
hausner 2012/10/22 20:00:29 Ditto regarding using a symbol.
1857 if (function().name() == equality_name.raw()) {
1858 compiler->EmitSuperEqualityCallPrologue(locs()->out().reg(), &skip_call);
1859 }
1855 compiler->GenerateStaticCall(deopt_id(), 1860 compiler->GenerateStaticCall(deopt_id(),
1856 token_pos(), 1861 token_pos(),
1857 function(), 1862 function(),
1858 ArgumentCount(), 1863 ArgumentCount(),
1859 argument_names(), 1864 argument_names(),
1860 locs()); 1865 locs());
1866 __ Bind(&skip_call);
1861 } 1867 }
1862 1868
1863 1869
1864 void AssertAssignableInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 1870 void AssertAssignableInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
1865 if (!is_eliminated()) { 1871 if (!is_eliminated()) {
1866 compiler->GenerateAssertAssignable(token_pos(), 1872 compiler->GenerateAssertAssignable(token_pos(),
1867 dst_type(), 1873 dst_type(),
1868 dst_name(), 1874 dst_name(),
1869 locs()); 1875 locs());
1870 } 1876 }
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
2210 new_max = new_max.Clamp(); 2216 new_max = new_max.Clamp();
2211 } 2217 }
2212 2218
2213 return Range::Update(&range_, new_min, new_max); 2219 return Range::Update(&range_, new_min, new_max);
2214 } 2220 }
2215 2221
2216 2222
2217 #undef __ 2223 #undef __
2218 2224
2219 } // namespace dart 2225 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/object.h » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698