Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 11230031: Android: replace NONE module class with GYP. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by Torne (Vacation until Jul 9)
Modified:
4 years, 8 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Android: replace NONE module class with GYP. Instead of mapping gyp's target_type: 'none' to an Android module class of NONE, map it to GYP. We are already using GYP for the shared intermediate directory, and this makes it clearer to Android users where these other intermediate directories came from. Committed: https://code.google.com/p/gyp/source/detail?r=1523

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pylib/gyp/generator/android.py View 1 chunk +1 line, -1 line 2 comments Download
M test/lib/TestGyp.py View 1 chunk +0 lines, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 4 (0 generated)
Torne (Vacation until Jul 9)
Hi Nico, One last change for Android: people have been confused by us creating an ...
4 years, 8 months ago (2012-10-22 17:10:47 UTC) #1
Nico (vacation Jun 30-Jul 11)
https://codereview.chromium.org/11230031/diff/1/pylib/gyp/generator/android.py File pylib/gyp/generator/android.py (right): https://codereview.chromium.org/11230031/diff/1/pylib/gyp/generator/android.py#newcode166 pylib/gyp/generator/android.py:166: self.android_class = MODULE_CLASSES.get(self.type, 'GYP') 'GYP' is fairly general. Maybe ...
4 years, 8 months ago (2012-10-22 17:15:21 UTC) #2
Torne (Vacation until Jul 9)
https://codereview.chromium.org/11230031/diff/1/pylib/gyp/generator/android.py File pylib/gyp/generator/android.py (right): https://codereview.chromium.org/11230031/diff/1/pylib/gyp/generator/android.py#newcode166 pylib/gyp/generator/android.py:166: self.android_class = MODULE_CLASSES.get(self.type, 'GYP') On 2012/10/22 17:15:22, Nico wrote: ...
4 years, 8 months ago (2012-10-23 09:54:03 UTC) #3
Nico (vacation Jun 30-Jul 11)
4 years, 8 months ago (2012-10-23 17:47:46 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 23e94e589