Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 11230031: Android: replace NONE module class with GYP. (Closed)

Created:
5 years, 1 month ago by Torne
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Android: replace NONE module class with GYP. Instead of mapping gyp's target_type: 'none' to an Android module class of NONE, map it to GYP. We are already using GYP for the shared intermediate directory, and this makes it clearer to Android users where these other intermediate directories came from. Committed: https://code.google.com/p/gyp/source/detail?r=1523

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pylib/gyp/generator/android.py View 1 chunk +1 line, -1 line 2 comments Download
M test/lib/TestGyp.py View 1 chunk +0 lines, -1 line 0 comments Download
Trybot results:

Messages

Total messages: 4 (0 generated)
Torne
Hi Nico, One last change for Android: people have been confused by us creating an ...
5 years, 1 month ago (2012-10-22 17:10:47 UTC) #1
Nico
https://codereview.chromium.org/11230031/diff/1/pylib/gyp/generator/android.py File pylib/gyp/generator/android.py (right): https://codereview.chromium.org/11230031/diff/1/pylib/gyp/generator/android.py#newcode166 pylib/gyp/generator/android.py:166: self.android_class = MODULE_CLASSES.get(self.type, 'GYP') 'GYP' is fairly general. Maybe ...
5 years, 1 month ago (2012-10-22 17:15:21 UTC) #2
Torne
https://codereview.chromium.org/11230031/diff/1/pylib/gyp/generator/android.py File pylib/gyp/generator/android.py (right): https://codereview.chromium.org/11230031/diff/1/pylib/gyp/generator/android.py#newcode166 pylib/gyp/generator/android.py:166: self.android_class = MODULE_CLASSES.get(self.type, 'GYP') On 2012/10/22 17:15:22, Nico wrote: ...
5 years, 1 month ago (2012-10-23 09:54:03 UTC) #3
Nico
5 years, 1 month ago (2012-10-23 17:47:46 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 0eb02b776