Issue 11230023: Web Intents Mac: Add view animation

Issue 11230023: Web Intents Mac: Add view animation (Closed)

Created:
8 years, 2 months ago by sail

Modified:
8 years, 2 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, groby+watch_chromium.org, Aaron Boodman, chromium-apps-reviews_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org, Nico

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Web Intents Mac: Add view animation With this CL we now animate when switching between web intent views. BUG=155887 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163521

Patch Set 2 : remove debug code #

Patch Set 4 : address review comment #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -34 lines)			Patch
M	chrome/browser/ui/cocoa/intents/web_intent_extension_prompt_view_controller.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_extension_prompt_view_controller.mm	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_inline_service_view_controller.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_picker_cocoa2.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_picker_cocoa2.mm	View		8 chunks	+30 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm	View	1 2 3	5 chunks	+46 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller_browsertest.mm	View	1 2	8 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_view_controller.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_view_controller.mm	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

LGTM http://codereview.chromium.org/11230023/diff/3001/chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm File chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm (right): http://codereview.chromium.org/11230023/diff/3001/chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm#newcode203 chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm:203: NSViewAnimationTargetKey: window, nit: align values, and on line ...

8 years, 2 months ago (2012-10-22 17:47:29 UTC) #2

sail

https://codereview.chromium.org/11230023/diff/3001/chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm File chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm (right): https://codereview.chromium.org/11230023/diff/3001/chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm#newcode203 chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm:203: NSViewAnimationTargetKey: window, On 2012/10/22 17:47:29, rsesek wrote: > nit: ...

8 years, 2 months ago (2012-10-22 17:54:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/11230023/6001

8 years, 2 months ago (2012-10-23 04:32:06 UTC) #4

Change committed as 163521

Expand Messages | Collapse Messages