Move more parts of stack trace formatting to runtime.

Move more parts of stack trace formatting to runtime.

R=ishell@chromium.org

Committed: https://crrev.com/7546302b6746940c7364d21ab2ac5fde386647c4
Cr-Commit-Position: refs/heads/master@{#28223}

[Igor Sheludko, 2015-05-05 10:30:49]

https://codereview.chromium.org/1122973002/diff/1/src/messages.cc
File src/messages.cc (right):

https://codereview.chromium.org/1122973002/diff/1/src/messages.cc#newcode201
src/messages.cc:201: Handle<JSFunction> fun) {
Maybe it's better to use LookupIterator here.

https://codereview.chromium.org/1122973002/diff/1/src/messages.cc#newcode235
src/messages.cc:235: Handle<Object> lookup(current->SlowReverseLookup(*fun_),
isolate);
SlowReverseLookup() does not look into accessor pairs and it does not handle
"multiple matches in the same object" case.

https://codereview.chromium.org/1122973002/diff/1/src/messages.cc#newcode237
src/messages.cc:237: if (!name.is_null()) break;
You probably wanted to return null at this point to avoid "multiple matches"
confusion (in this case please add a comment here).

If not, then why do we need to perform another iteration before exiting the
loop? Why not just break after
  name = lookup;
?

[Yang, 2015-05-05 11:46:56]

Addressed all comments. Please take another look.

[Yang, 2015-05-05 13:03:29]

On 2015/05/05 11:46:56, Yang wrote:
> Addressed all comments. Please take another look.

Addressed offline comments.

[Igor Sheludko, 2015-05-05 13:18:01]

lgtm

[Yang, 2015-05-05 13:19:53]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-05-05 13:20:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1122973002/40001

[commit-bot: I haz the power, 2015-05-05 13:55:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-05 14:18:01]

Patchset 3 (id:??) landed as
https://crrev.com/7546302b6746940c7364d21ab2ac5fde386647c4
Cr-Commit-Position: refs/heads/master@{#28223}