Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: sync/notifier/sync_invalidation_listener.cc

Issue 11229015: Add the InvalidationState struct to bundle local state about invalidations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/notifier/sync_invalidation_listener.h ('k') | sync/notifier/sync_invalidation_listener_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/notifier/sync_invalidation_listener.cc
diff --git a/sync/notifier/sync_invalidation_listener.cc b/sync/notifier/sync_invalidation_listener.cc
index ab70527f610096d47db0283c3acdaa90bbb22bd8..c9478597279f1c67b45ecf8c4664e9282a631bd8 100644
--- a/sync/notifier/sync_invalidation_listener.cc
+++ b/sync/notifier/sync_invalidation_listener.cc
@@ -52,7 +52,7 @@ void SyncInvalidationListener::Start(
create_invalidation_client_callback,
const std::string& client_id, const std::string& client_info,
const std::string& invalidation_bootstrap_data,
- const InvalidationVersionMap& initial_max_invalidation_versions,
+ const InvalidationStateMap& initial_invalidation_state_map,
const WeakHandle<InvalidationStateTracker>& invalidation_state_tracker,
Delegate* delegate) {
DCHECK(CalledOnValidThread());
@@ -67,16 +67,16 @@ void SyncInvalidationListener::Start(
sync_system_resources_.storage()->SetInitialState(
invalidation_bootstrap_data);
- max_invalidation_versions_ = initial_max_invalidation_versions;
- if (max_invalidation_versions_.empty()) {
+ invalidation_state_map_ = initial_invalidation_state_map;
+ if (invalidation_state_map_.empty()) {
DVLOG(2) << "No initial max invalidation versions for any id";
} else {
- for (InvalidationVersionMap::const_iterator it =
- max_invalidation_versions_.begin();
- it != max_invalidation_versions_.end(); ++it) {
+ for (InvalidationStateMap::const_iterator it =
+ invalidation_state_map_.begin();
+ it != invalidation_state_map_.end(); ++it) {
DVLOG(2) << "Initial max invalidation version for "
<< ObjectIdToString(it->first) << " is "
- << it->second;
+ << it->second.version;
}
}
invalidation_state_tracker_ = invalidation_state_tracker;
@@ -141,17 +141,16 @@ void SyncInvalidationListener::Invalidate(
// should drop invalidations for unregistered ids. We may also
// have to filter it at a higher level, as invalidations for
// newly-unregistered ids may already be in flight.
- InvalidationVersionMap::const_iterator it =
- max_invalidation_versions_.find(id);
- if ((it != max_invalidation_versions_.end()) &&
- (invalidation.version() <= it->second)) {
+ InvalidationStateMap::const_iterator it = invalidation_state_map_.find(id);
+ if ((it != invalidation_state_map_.end()) &&
+ (invalidation.version() <= it->second.version)) {
// Drop redundant invalidations.
client->Acknowledge(ack_handle);
return;
}
DVLOG(2) << "Setting max invalidation version for " << ObjectIdToString(id)
<< " to " << invalidation.version();
- max_invalidation_versions_[id] = invalidation.version();
+ invalidation_state_map_[id].version = invalidation.version();
invalidation_state_tracker_.Call(
FROM_HERE,
&InvalidationStateTracker::SetMaxVersion,
@@ -313,7 +312,7 @@ void SyncInvalidationListener::Stop() {
delegate_ = NULL;
invalidation_state_tracker_.Reset();
- max_invalidation_versions_.clear();
+ invalidation_state_map_.clear();
ticl_state_ = DEFAULT_INVALIDATION_ERROR;
push_client_state_ = DEFAULT_INVALIDATION_ERROR;
}
« no previous file with comments | « sync/notifier/sync_invalidation_listener.h ('k') | sync/notifier/sync_invalidation_listener_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698