Issue 1122883002: Do not suppress implicit constructors that need a super call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1122883002: Do not suppress implicit constructors that need a super call. (Closed)

Created:
5 years, 7 months ago by vsm

Modified:
5 years, 7 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Do not suppress implicit constructors that need a super call. This fixes a bug creating an _AsyncCompleter (_Completer.future was not being initialized). R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/194ab199abc5e577e06dd465a40771939f8a89ad

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -7 lines)			Patch
M	lib/runtime/dart/_interceptors.js	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	lib/runtime/dart/_js_helper.js	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	lib/runtime/dart/_native_typed_data.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/runtime/dart/async.js	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	lib/runtime/dart/collection.js	View	4 chunks	+12 lines, -0 lines	0 comments	Download
M	lib/runtime/dart/convert.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/runtime/dart/core.js	View	1 chunk	+13 lines, -2 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/codegen/expect/cascade.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/codegen/expect/covariance.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

vsm

5 years, 7 months ago (2015-05-04 21:50:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
194ab199abc5e577e06dd465a40771939f8a89ad (presubmit successful).