Issue 1122863003: Revert of Pepper: Fix reentrancy problem in PepperPluginInstanceImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1122863003: Revert of Pepper: Fix reentrancy problem in PepperPluginInstanceImpl. (Closed)

Created:
5 years, 7 months ago by bbudge

Modified:
5 years, 7 months ago

Reviewers:
raymes

CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, amineer

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Pepper: Fix reentrancy problem in PepperPluginInstanceImpl. (patchset #4 id:60001 of https://codereview.chromium.org/1085423004/) Reason for revert: This didn't fix the issue (The fix will be in Blink WebPlugin code.) Original issue's description: > Changes PepperPluginInstanceImpl::IsRectTopmost to not use > container_ if we are destroying the instance. > > BUG=476590 > > Committed: https://crrev.com/2233759a94e368576ba7ce2968f77b22450d2c85 > Cr-Commit-Position: refs/heads/master@{#325561} TBR=raymes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476590 Committed: https://crrev.com/31550440437c706608692f7d4eb39067650054c1 Cr-Commit-Position: refs/heads/master@{#328196}

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	content/renderer/pepper/pepper_plugin_instance_impl.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

bbudge

Created Revert of Pepper: Fix reentrancy problem in PepperPluginInstanceImpl.

5 years, 7 months ago (2015-05-04 21:46:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122863003/1

5 years, 7 months ago (2015-05-04 21:49:55 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-04 21:53:43 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/31550440437c706608692f7d4eb39067650054c1
Cr-Commit-Position: refs/heads/master@{#328196}