Chromium Code Reviews

Issue 1122823002: When adding constant string with something unknown, assume it's a string. (Closed)

Created:
5 years, 7 months ago by Igor Sheludko
Modified:
5 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

When adding constant string with something unknown, assume it's a string. Committed: https://crrev.com/1c74ca661972d0abd9afb5f8b195411d48483135 Cr-Commit-Position: refs/heads/master@{#28221}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+21 lines, -6 lines)
M src/hydrogen.cc View 1 chunk +21 lines, -6 lines 0 comments

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 7 months ago (2015-05-05 08:47:21 UTC) #2
Toon Verwaest
lgtm
5 years, 7 months ago (2015-05-05 11:31:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122823002/1
5 years, 7 months ago (2015-05-05 12:29:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 12:47:10 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 12:47:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c74ca661972d0abd9afb5f8b195411d48483135
Cr-Commit-Position: refs/heads/master@{#28221}

Powered by Google App Engine