Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1122813002: Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/11188… (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/)" Fixed serialization from prev CL This reverts commit 973d1f1f60f2710a268a3165aa4f3460502d4be5. BUG=skia:3803 TBR= Committed: https://skia.googlesource.com/skia/+/5392785080001fe737fac9e5801fc2127a78d4fb

Patch Set 1 #

Patch Set 2 : patch old picture to make serialize work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -58 lines) Patch
M include/core/SkDevice.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkImage.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +51 lines, -5 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 chunks +17 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +43 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122813002/20001
5 years, 7 months ago (2015-05-04 17:24:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122813002/20001
5 years, 7 months ago (2015-05-04 17:49:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/5392785080001fe737fac9e5801fc2127a78d4fb
5 years, 7 months ago (2015-05-04 17:49:46 UTC) #6
reed1
5 years, 7 months ago (2015-05-05 12:41:30 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1123743006/ by reed@google.com.

The reason for reverting is: did not update DeferredCanvas.

Powered by Google App Engine
This is Rietveld 408576698