Issue 11228040: Move sandbox code in content to content namespace.

Issue 11228040: Move sandbox code in content to content namespace. (Closed)

Created:
8 years, 2 months ago by jam

Modified:
8 years, 2 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move sandbox code in content to content namespace. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163656

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -157 lines)			Patch
M	chrome/test/base/chrome_test_launcher.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/child_process_launcher.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/common/sandbox_init_mac.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/common/sandbox_init_win.cc	View		3 chunks	+3 lines, -4 lines	0 comments	Download
M	content/common/sandbox_mac.h	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	content/common/sandbox_mac.mm	View		7 chunks	+15 lines, -16 lines	0 comments	Download
M	content/common/sandbox_mac_diraccess_unittest.mm	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/common/sandbox_mac_fontloading_unittest.mm	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	content/common/sandbox_mac_system_access_unittest.mm	View		5 chunks	+8 lines, -10 lines	0 comments	Download
M	content/common/sandbox_mac_unittest_helper.h	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	content/common/sandbox_mac_unittest_helper.mm	View		7 chunks	+10 lines, -18 lines	0 comments	Download
M	content/common/sandbox_policy.h	View		1 chunk	+4 lines, -13 lines	0 comments	Download
M	content/common/sandbox_policy.cc	View		9 chunks	+35 lines, -45 lines	0 comments	Download
M	content/public/app/startup_helper_win.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/public/common/sandbox_init.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/test/test_launcher.h	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	content/public/test/test_launcher.cc	View		4 chunks	+12 lines, -13 lines	0 comments	Download
M	content/public/test/test_utils.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/test/content_test_launcher.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

8 years, 2 months ago (2012-10-23 19:40:14 UTC) #2

the rest lgtm

http://codereview.chromium.org/11228040/diff/1021/content/common/sandbox_mac.h
File content/common/sandbox_mac.h (right):

http://codereview.chromium.org/11228040/diff/1021/content/common/sandbox_mac....
content/common/sandbox_mac.h:29: class SandboxSubstring {
would it be too much trouble to move this stuff into into src\sandbox\mac or
\osx ?

It used to be that src\sandbox only had windows stuff but nowadays it has
\windows and \linux

Expand Messages | Collapse Messages