Issue 1122803002: Revert of make drawImage a virtual on SkDevice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1122803002: Revert of make drawImage a virtual on SkDevice (Closed)

Created:
5 years, 7 months ago by reed1

Modified:
5 years, 7 months ago

Reviewers:
bsalomon, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/) Reason for revert: need to make serialization work for pictures, now that images are "real" Original issue's description: > make drawImage a virtual on SkDevice > > default impl will turn the Image into a (raster) bitmap and call drawBitmap. > > BUG=skia:3803 > > Committed: https://skia.googlesource.com/skia/+/f603fb3d0e5fa57c3f228d66945bef198b001135 TBR=bsalomon@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3803 Committed: https://skia.googlesource.com/skia/+/973d1f1f60f2710a268a3165aa4f3460502d4be5

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -121 lines)			Patch
M	include/core/SkDevice.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	include/core/SkImage.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	2 chunks	+5 lines, -51 lines	0 comments	Download
M	src/core/SkDevice.cpp	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	src/gpu/SkGpuDevice.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 chunk	+0 lines, -43 lines	0 comments	Download
M	src/image/SkImage.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/image/SkImage_Base.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/image/SkImage_Gpu.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/image/SkImage_Gpu.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/image/SkImage_Raster.cpp	View	2 chunks	+13 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122803002/1

5 years, 7 months ago (2015-05-04 16:00:29 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-04 16:00:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/973d1f1f60f2710a268a3165aa4f3460502d4be5