Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: runtime/vm/flow_graph_allocator.cc

Issue 11228025: Allow splitting at lifetime holes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_allocator.cc
diff --git a/runtime/vm/flow_graph_allocator.cc b/runtime/vm/flow_graph_allocator.cc
index ed0d2625bb29057dc9d1e6904ce30ac9e043dfd7..ba81b7051fd1d88b6c45a0db64e6b282649a644e 100644
--- a/runtime/vm/flow_graph_allocator.cc
+++ b/runtime/vm/flow_graph_allocator.cc
@@ -1353,8 +1353,9 @@ LiveRange* LiveRange::SplitAt(intptr_t split_pos) {
ASSERT(split_pos < End());
- // Corner case. We need to start over to find previous interval.
- if (interval->start() == split_pos) interval = first_use_interval_;
+ // Corner case. Split position can be inside the lifetime hole or at its
Florian Schneider 2012/10/22 13:08:53 did you mean: inside _a_ lifetime hole?
+ // end. We need to start over to find the previous interval.
+ if (split_pos <= interval->start()) interval = first_use_interval_;
UseInterval* last_before_split = NULL;
while (interval->end() <= split_pos) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698