Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1122763003: Allow safe_browsing_mode overriding in gn build (Closed)

Created:
5 years, 7 months ago by Tomasz Moniuszko
Modified:
5 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow safe_browsing_mode overriding in gn build BUG= Committed: https://crrev.com/c01623f93b4c741608cc607bfbf71c95a97a76e4 Cr-Commit-Position: refs/heads/master@{#328298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M build/config/features.gni View 2 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tomasz Moniuszko
5 years, 7 months ago (2015-05-04 13:56:42 UTC) #2
brettw
lgtm
5 years, 7 months ago (2015-05-04 17:28:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122763003/1
5 years, 7 months ago (2015-05-05 07:25:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 08:05:18 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 08:06:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c01623f93b4c741608cc607bfbf71c95a97a76e4
Cr-Commit-Position: refs/heads/master@{#328298}

Powered by Google App Engine
This is Rietveld 408576698