Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1122753002: [turbofan] Small fixes to PipelineStatistics. Collect statistics in tests. (Closed)

Created:
5 years, 7 months ago by titzer
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Small fixes to PipelineStatistics. Collect statistics in tests. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/9833844268357590243732a53e2a7fc0dc5fcc9e Cr-Commit-Position: refs/heads/master@{#28192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/compiler/pipeline.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/pipeline-statistics.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
titzer
5 years, 7 months ago (2015-05-04 10:39:39 UTC) #1
Benedikt Meurer
lgtm
5 years, 7 months ago (2015-05-04 10:53:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122753002/1
5 years, 7 months ago (2015-05-04 11:03:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-04 11:05:50 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9833844268357590243732a53e2a7fc0dc5fcc9e Cr-Commit-Position: refs/heads/master@{#28192}
5 years, 7 months ago (2015-05-04 11:05:57 UTC) #6
Michael Achenbach
[Sheriff] Speculative revert for breaking arm64 nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%202/builds/2314
5 years, 7 months ago (2015-05-04 15:36:07 UTC) #8
Michael Achenbach
5 years, 7 months ago (2015-05-04 15:38:42 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1119963003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for breaking arm64
nosnap:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s....

Powered by Google App Engine
This is Rietveld 408576698