Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1122723005: Rename renderer to layoutObject in core/editing. (Closed)

Created:
5 years, 7 months ago by dsinclair
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, groby+blinkspell_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Rename renderer to layoutObject in core/editing. This Cl updates the core/editing code to use layoutObject instead of renderer. BUG=462960 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -256 lines) Patch
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Caret.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Caret.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/EditingBehavior.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/PlainTextRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/RenderedPosition.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/RenderedPosition.cpp View 9 chunks +26 lines, -26 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 14 chunks +36 lines, -36 lines 0 comments Download
M Source/core/editing/VisibleUnits.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 7 chunks +17 lines, -17 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 10 chunks +27 lines, -27 lines 0 comments Download
M Source/core/editing/iterators/CharacterIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/FullyClippedStateStack.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 4 chunks +18 lines, -18 lines 0 comments Download
M Source/core/editing/iterators/TextIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/TextIterator.cpp View 21 chunks +52 lines, -52 lines 0 comments Download
M Source/core/editing/iterators/TextIteratorTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/iterators/TextIteratorTextState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/TextIteratorTextState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL.
5 years, 7 months ago (2015-05-05 16:50:49 UTC) #2
eae
Awesome, thanks so much for doing this Dan! LGTM
5 years, 7 months ago (2015-05-05 16:58:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122723005/1
5 years, 7 months ago (2015-05-05 16:59:38 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 20:16:38 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194938

Powered by Google App Engine
This is Rietveld 408576698