Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: tests/compiler/dart2js_extra/named_parameter_for_static_test.dart

Issue 11227038: Fix and reenable dart2js extra tests and dart2js native tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js_extra/named_parameter_for_static_test.dart
===================================================================
--- tests/compiler/dart2js_extra/named_parameter_for_static_test.dart (revision 13907)
+++ tests/compiler/dart2js_extra/named_parameter_for_static_test.dart (working copy)
@@ -2,12 +2,12 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-oneOptionalArgument(a, [b]) {
+oneOptionalArgument(a, {b}) {
Expect.equals(1, a);
Expect.equals(2, b);
}
-twoOptionalArguments([a, b]) {
+twoOptionalArguments({a, b}) {
Expect.equals(1, a);
Expect.equals(2, b);
}
@@ -15,56 +15,43 @@
main() {
twoOptionalArguments(a: 1, b: 2);
twoOptionalArguments(b: 2, a: 1);
- twoOptionalArguments(1, b: 2);
- twoOptionalArguments(1, 2);
- oneOptionalArgument(1, 2);
oneOptionalArgument(1, b: 2);
new A.twoOptionalArguments(a: 1, b: 2);
new A.twoOptionalArguments(b: 2, a: 1);
- new A.twoOptionalArguments(1, b: 2);
- new A.twoOptionalArguments(1, 2);
- new A.oneOptionalArgument(1, 2);
new A.oneOptionalArgument(1, b: 2);
-/* TODO(ngeoffray): Enable once we support super constructor call.
new B.one();
new B.two();
new B.three();
- new B.four();
- new B.five();
- new B.six();
-*/
- new B().one();
- new B().two();
- new B().three();
- new B().four();
- new B().five();
- new B().six();
+ new B().B_one();
+ new B().B_two();
+ new B().B_three();
}
class A {
- A.oneOptionalArgument(a, [b]) {
+ A.oneOptionalArgument(a, {b}) {
Expect.equals(1, a);
Expect.equals(2, b);
}
- A.twoOptionalArguments([a, b]) {
+ A.twoOptionalArguments({a, b}) {
Expect.equals(1, a);
Expect.equals(2, b);
}
A();
- oneOptionalArgument(a, [b]) {
+ // A named constructor now conflicts with a method of the same name.
+ oneOptArg(a, {b}) {
Expect.equals(1, a);
Expect.equals(2, b);
}
- twoOptionalArguments([a, b]) {
+ twoOptArgs({a, b}) {
Expect.equals(1, a);
Expect.equals(2, b);
}
@@ -73,16 +60,10 @@
class B extends A {
B.one() : super.twoOptionalArguments(a: 1, b: 2);
B.two() : super.twoOptionalArguments(b: 2, a: 1);
- B.three() : super.twoOptionalArguments(1, b: 2);
- B.four() : super.twoOptionalArguments(1, 2);
- B.five() : super.oneOptionalArgument(1, 2);
- B.six() : super.oneOptionalArgument(1, b: 2);
+ B.three() : super.oneOptionalArgument(1, b: 2);
B();
- one() { super.twoOptionalArguments(a: 1, b: 2); }
- two() { super.twoOptionalArguments(b: 2, a: 1); }
- three() { super.twoOptionalArguments(1, b: 2); }
- four() { super.twoOptionalArguments(1, 2); }
- five() { super.oneOptionalArgument(1, 2); }
- six() { super.oneOptionalArgument(1, b: 2); }
+ B_one() { super.twoOptArgs(a: 1, b: 2); }
+ B_two() { super.twoOptArgs(b: 2, a: 1); }
+ B_three() { super.oneOptArg(1, b: 2); }
}
« no previous file with comments | « tests/compiler/dart2js_extra/dart2js_extra.status ('k') | tests/compiler/dart2js_extra/named_parameter_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698