Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 11227018: Font Settings API: UI overhaul of example extension. (Closed)

Created:
8 years, 2 months ago by falken
Modified:
8 years, 2 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Font Settings API: UI overhaul of example extension. Based on suggestions from UI review and Marcin Wichary. This change copies several files required to use the list and overlay/popup widgets of Chrome. BUG=114805 TBR=mpcomplete Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163241

Patch Set 1 #

Patch Set 2 : indent fix in html #

Patch Set 3 : update version and description string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -166 lines) Patch
A + chrome/common/extensions/docs/examples/api/fontSettings/css/list.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/css/overlay.css View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/images/x.png View Binary file 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/images/x-hover.png View Binary file 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/images/x-pressed.png View Binary file 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr/event_target.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/array_data_model.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/list.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/list_item.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/list_selection_controller.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/list_selection_model.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/list_single_selection_model.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/overlay.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/touch_handler.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/event_tracker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/fontSettings/js/util.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/manifest.json View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/options.html View 1 2 2 chunks +204 lines, -114 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/options.js View 8 chunks +194 lines, -60 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
falken
Hi Matt, This is a UI overhaul of the example extension. All the new files ...
8 years, 2 months ago (2012-10-22 06:22:44 UTC) #1
Matt Perry
LGTM. If this is intended to be a component extension, it can access chrome:// resources ...
8 years, 2 months ago (2012-10-22 21:32:26 UTC) #2
falken
Thanks for reviewing. Can you point me to documentation or other background information about component ...
8 years, 2 months ago (2012-10-23 01:49:52 UTC) #3
Matt Perry
Not sure if there is documentation. A component extension is just one that is bundled ...
8 years, 2 months ago (2012-10-23 01:52:47 UTC) #4
falken
I see. Does this mean the extension is always enabled (i.e., it's not in the ...
8 years, 2 months ago (2012-10-23 02:09:05 UTC) #5
Matt Perry
8 years, 2 months ago (2012-10-23 18:15:21 UTC) #6
On 2012/10/23 02:09:05, falken wrote:
> I see. Does this mean the extension is always enabled (i.e., it's not in the
Web
> Store and can't be enabled/disabled in chrome://chrome/extensions)?

Yes. It doesn't show up in chrome:extensions either. The bookmark manager is a
component extension, for example.

Powered by Google App Engine
This is Rietveld 408576698