Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1769)

Unified Diff: android_webview/browser/net/aw_url_request_job_factory.h

Issue 11227017: Remove the mutation functions interfaces from URLRequestJobFactory. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix Android Webview interfaces; also a long awaited rebase. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/net/aw_url_request_job_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/net/aw_url_request_job_factory.h
diff --git a/android_webview/browser/net/aw_url_request_job_factory.h b/android_webview/browser/net/aw_url_request_job_factory.h
index 3201fbd77dab307791396604f05f8797daf097d4..aaf09480b244466c97656f3bff08bd2750d2a50d 100644
--- a/android_webview/browser/net/aw_url_request_job_factory.h
+++ b/android_webview/browser/net/aw_url_request_job_factory.h
@@ -8,6 +8,10 @@
#include "base/memory/scoped_ptr.h"
#include "net/url_request/url_request_job_factory.h"
+namespace net {
+class URLRequestJobFactoryImpl;
+} // namespace net
+
namespace android_webview {
// android_webview uses a custom URLRequestJobFactoryImpl to support
@@ -21,9 +25,6 @@ class AwURLRequestJobFactory : public net::URLRequestJobFactory {
AwURLRequestJobFactory();
virtual ~AwURLRequestJobFactory();
- virtual bool SetProtocolHandler(const std::string& scheme,
- ProtocolHandler* protocol_handler) OVERRIDE;
- virtual void AddInterceptor(Interceptor* interceptor) OVERRIDE;
virtual net::URLRequestJob* MaybeCreateJobWithInterceptor(
net::URLRequest* request,
net::NetworkDelegate* network_delegate) const OVERRIDE;
@@ -40,11 +41,14 @@ class AwURLRequestJobFactory : public net::URLRequestJobFactory {
net::NetworkDelegate* network_delegate) const OVERRIDE;
virtual bool IsHandledProtocol(const std::string& scheme) const OVERRIDE;
virtual bool IsHandledURL(const GURL& url) const OVERRIDE;
+ bool SetProtocolHandler(const std::string& scheme,
+ ProtocolHandler* protocol_handler);
+ void AddInterceptor(Interceptor* interceptor);
private:
// By default calls are forwarded to this factory, to avoid having to
// subclass an existing implementation class.
- scoped_ptr<URLRequestJobFactory> next_factory_;
+ scoped_ptr<net::URLRequestJobFactoryImpl> next_factory_;
DISALLOW_COPY_AND_ASSIGN(AwURLRequestJobFactory);
};
« no previous file with comments | « no previous file | android_webview/browser/net/aw_url_request_job_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698