Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1122633002: Fix silly python exception when printing error message. (Closed)

Created:
5 years, 7 months ago by newt (away)
Modified:
5 years, 7 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix silly python exception when printing error message. Oh, Python, I may never understand you completely. Committed: https://crrev.com/2e7a8c4e93366cf8a35363f5f43f0c08925c6410 Cr-Commit-Position: refs/heads/master@{#328046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/gyp/jinja_template.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 7 months ago (2015-05-02 00:45:33 UTC) #2
cjhopman
lgtm
5 years, 7 months ago (2015-05-02 00:46:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122633002/1
5 years, 7 months ago (2015-05-02 01:19:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-02 02:30:05 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-02 02:31:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e7a8c4e93366cf8a35363f5f43f0c08925c6410
Cr-Commit-Position: refs/heads/master@{#328046}

Powered by Google App Engine
This is Rietveld 408576698