chrome/common/BUILD.gn - Issue 1122613002: Make the Windows multi_dll build work in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/BUILD.gn

Issue 1122613002: Make the Windows multi_dll build work in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@buildflags

Patch Set: chromeos and android Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/BUILD.gn

diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn

index 1985599cab6e25717747a74565c94b2aa3a17f79..c7b0eadd1fe079e881e5f00e9ae5ccffb8439a5b 100644

--- a/chrome/common/BUILD.gn

+++ b/chrome/common/BUILD.gn

@@ -55,6 +55,7 @@ static_library("common") {

"//chrome/common/safe_browsing:proto",

"//chrome/installer/util",

"//components/cloud_devices/common",

+ "//components/component_updater",

"//components/content_settings/core/common",

"//components/favicon_base",

"//components/json_schema",

@@ -191,7 +192,10 @@ static_library("common") {

}

if (is_win) {

- deps += [ "//third_party/wtl" ]

+ deps += [

+ "//components/dom_distiller/core", # Needed by chrome_content_client.cc.

+ "//third_party/wtl",

+ ]

}

if (enable_mdns) {

« no previous file with comments | « chrome/browser/extensions/BUILD.gn ('k') | chrome/common/extensions/api/BUILD.gn » ('j') | no next file with comments »