Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Unified Diff: base/trace_event/etw_manifest/BUILD.gn

Issue 1122613002: Make the Windows multi_dll build work in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@buildflags
Patch Set: chromeos and android Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/json_schema_api.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/etw_manifest/BUILD.gn
diff --git a/base/trace_event/etw_manifest/BUILD.gn b/base/trace_event/etw_manifest/BUILD.gn
index 07cf80edcc9dadb3a5e4198d7f88a820c9a02188..f62e356b118ba343c540863123b28cdf96c90229 100644
--- a/base/trace_event/etw_manifest/BUILD.gn
+++ b/base/trace_event/etw_manifest/BUILD.gn
@@ -5,11 +5,8 @@
assert(is_win, "This only runs on Windows.")
# Makes the .h/.rc files from the .man file.
-action("chrome_events_win") {
- visibility = [
- "//base/trace_event/*",
- "//chrome:main_dll",
- ]
+action("chrome_events_win_generate") {
+ visibility = [ ":*" ]
script = "build/message_compiler.py"
sources = [
@@ -35,3 +32,17 @@ action("chrome_events_win") {
rebase_path("chrome_events_win.man", root_build_dir),
]
}
+
+# Compile the generated files.
+source_set("chrome_events_win") {
+ visibility = [
+ "//base/trace_event/*",
+ "//chrome:main_dll",
+ ]
+
+ sources = get_target_outputs(":chrome_events_win_generate")
+
+ deps = [
+ ":chrome_events_win_generate",
+ ]
+}
« no previous file with comments | « no previous file | build/json_schema_api.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698