Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1122613002: Make the Windows multi_dll build work in GN (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, aandrey+blink_chromium.org, wfh+watch_chromium.org, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, tracing+reviews_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@buildflags
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the Windows multi_dll build work in GN This patch still keeps the flag disabled, I will toggle that in a separate patch to reduce risk. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/22488ada37ee94a2e774bbbeb10b0f8f8ea19275 Cr-Commit-Position: refs/heads/master@{#328031}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : chromeos and android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -41 lines) Patch
M base/trace_event/etw_manifest/BUILD.gn View 2 chunks +16 lines, -5 lines 0 comments Download
M build/json_schema_api.gni View 7 chunks +61 lines, -32 lines 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/net/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/child/BUILD.gn View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
brettw
https://codereview.chromium.org/1122613002/diff/20001/chrome/browser/extensions/BUILD.gn File chrome/browser/extensions/BUILD.gn (left): https://codereview.chromium.org/1122613002/diff/20001/chrome/browser/extensions/BUILD.gn#oldcode18 chrome/browser/extensions/BUILD.gn:18: static_library("extensions") { This change isn't strictly required.
5 years, 7 months ago (2015-05-01 22:38:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122613002/20001
5 years, 7 months ago (2015-05-01 22:41:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122613002/20001
5 years, 7 months ago (2015-05-01 22:43:15 UTC) #7
scottmg
lgtm
5 years, 7 months ago (2015-05-01 22:47:22 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/33481)
5 years, 7 months ago (2015-05-01 23:08:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122613002/40001
5 years, 7 months ago (2015-05-01 23:39:19 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-02 00:43:14 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-02 00:44:09 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/22488ada37ee94a2e774bbbeb10b0f8f8ea19275
Cr-Commit-Position: refs/heads/master@{#328031}

Powered by Google App Engine
This is Rietveld 408576698