Incognito-allowed package apps produce duplicate items in context menu

chrome/browser/profiles/off_the_record_profile_impl.cc

Index: chrome/browser/profiles/off_the_record_profile_impl.cc
diff --git a/chrome/browser/profiles/off_the_record_profile_impl.cc b/chrome/browser/profiles/off_the_record_profile_impl.cc
index 88080b2c56060d64adcd02f157bcd9549bd85083..f16bcbc6d5d82d2f237a5785afe6fbb3abf68cb9 100644
--- a/chrome/browser/profiles/off_the_record_profile_impl.cc
+++ b/chrome/browser/profiles/off_the_record_profile_impl.cc
@@ -135,6 +135,7 @@ OffTheRecordProfileImpl::~OffTheRecordProfileImpl() {
   if (extension_service && extension_service->extensions_enabled()) {
     extension_service->extension_prefs()->
         ClearIncognitoSessionOnlyContentSettings();
+    extension_service->menu_manager()->RemoveAllIncognitoContextItems();

[sail, 2012/10/25 19:22:00]

This needs a test (something that doesn't pass without your patch and passes
with your patch).

[Joe Thomas, 2012/10/25 19:49:42]

I already added a unit test for the new function that I created in
menu_manager_unittest.cc.

Testing the complete use case requires creating and destroying incognito window
multiple times and navigate through the context menu items of incognito window.
I am not quite sure how to do that. Do we have any similar testcase that I can
look into?

[sail, 2012/10/25 19:56:14]

Take a look at profile_browsertest.cc and profile_manager_browsertest.cc.
It's fairly easy to create new incognito windows from browser tests.

   }
 
   ProfileDependencyManager::GetInstance()->DestroyProfileServices(this);