Incognito-allowed package apps produce duplicate items in context menu

chrome/browser/extensions/menu_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
@@ skipping 28 matching lines @@
 // Base class for tests.
 class MenuManagerTest : public testing::Test {
  public:
   MenuManagerTest() : ui_thread_(BrowserThread::UI, &message_loop_),
                       file_thread_(BrowserThread::FILE, &message_loop_),
                       manager_(&profile_),
                       next_id_(1) {
   }
 
   // Returns a test item.
-  MenuItem* CreateTestItem(Extension* extension) {
+  MenuItem* CreateTestItem(Extension* extension, bool incognito = false) {
     MenuItem::Type type = MenuItem::NORMAL;
     MenuItem::ContextList contexts(MenuItem::ALL);
-    MenuItem::Id id(false, extension->id());
+    MenuItem::Id id(incognito, extension->id());
     id.uid = next_id_++;
     return new MenuItem(id, "test", false, true, type, contexts);
   }
 
   // Returns a test item with the given string ID.
   MenuItem* CreateTestItemWithID(Extension* extension,
                                  const std::string& string_id) {
     MenuItem::Type type = MenuItem::NORMAL;
     MenuItem::ContextList contexts(MenuItem::ALL);
     MenuItem::Id id(false, extension->id());
@@ skipping 621 matching lines @@
   ASSERT_TRUE(new_item->checked());
   ASSERT_TRUE(child1->checked());
 
   // Removing |parent| should cause only |child1| to be selected.
   manager_.RemoveContextMenuItem(parent->id());
   parent = NULL;
   ASSERT_FALSE(new_item->checked());
   ASSERT_TRUE(child1->checked());
 }
 
+// Tests the RemoveAllIncognitoContextItems functionality.
+TEST_F(MenuManagerTest, RemoveAllIncognito) {
+  Extension* extension1 = AddExtension("1111");
+  // Add 2 top-level and one child item for extension 1
+  // with incognito 'true'.
+  MenuItem* item1 = CreateTestItem(extension1, true);
+  MenuItem* item2 = CreateTestItem(extension1, true);
+  MenuItem* item3 = CreateTestItem(extension1, true);
+  ASSERT_TRUE(manager_.AddContextItem(extension1, item1));
+  ASSERT_TRUE(manager_.AddContextItem(extension1, item2));
+  ASSERT_TRUE(manager_.AddChildItem(item1->id(), item3));
+
+  // Add 2 top-level and one child item for extension 1
+  // with incognito 'false'.
+  MenuItem* item4 = CreateTestItem(extension1);
+  MenuItem* item5 = CreateTestItem(extension1);
+  MenuItem* item6 = CreateTestItem(extension1);
+  ASSERT_TRUE(manager_.AddContextItem(extension1, item4));
+  ASSERT_TRUE(manager_.AddContextItem(extension1, item5));
+  ASSERT_TRUE(manager_.AddChildItem(item4->id(), item6));
+
+  // Add one top-level item for extension 2.
+  Extension* extension2 = AddExtension("2222");
+  MenuItem* item7 = CreateTestItem(extension2);
+  ASSERT_TRUE(manager_.AddContextItem(extension2, item7));
+
+  EXPECT_EQ(4u, manager_.MenuItems(extension1->id())->size());
+  EXPECT_EQ(1u, manager_.MenuItems(extension2->id())->size());
+
+  // Remove all context menu items with incognito true.
+  manager_.RemoveAllIncognitoContextItems();
+  EXPECT_EQ(2u, manager_.MenuItems(extension1->id())->size());
+  EXPECT_EQ(1u, manager_.MenuItems(extension2->id())->size());
+}
+
 }  // namespace extensions