Incognito-allowed package apps produce duplicate items in context menu

chrome/browser/extensions/extension_process_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 604 matching lines @@
     }
 
     case content::NOTIFICATION_WEB_CONTENTS_CONNECTED: {
       content::WebContents* contents =
           content::Source<content::WebContents>(source).ptr();
       UpdateRegisteredRenderView(contents->GetRenderViewHost());
       break;
     }
 
     case chrome::NOTIFICATION_PROFILE_DESTROYED: {
+      // Remove "incognito" "split" mode context menu items.
+      Profile* profile = content::Source<Profile>(source).ptr();

[Yoyo Zhou, 2012/10/29 21:26:51]

Note that only the incognito profile's ExtensionProcessManager will see this
event from the incognito profile. So you could do this cleanup in the destructor
of IncognitoExtensionProcessManager instead, since it has the same lifetime as
the incognito profile.

This is probably okay for now (to fix this bug), but there's definitely a
modularity issue, since this code isn't related to the ExtensionProcessManager,
but only to the lifetime of the incognito profile. Can you add a
TODO(yoz): This cleanup code belongs in the MenuManager.

+      if (profile->IsOffTheRecord()) {
+          ExtensionService* service =
+            extensions::ExtensionSystem::Get(profile)->extension_service();
+          service->menu_manager()->RemoveAllIncognitoContextItems();
+      }
       // Close background hosts when the last browser is closed so that they
       // have time to shutdown various objects on different threads. Our
       // destructor is called too late in the shutdown sequence.
       CloseBackgroundHosts();
       break;
     }
 
     case content::NOTIFICATION_DEVTOOLS_AGENT_ATTACHED: {
       RenderViewHost* render_view_host =
           content::Details<RenderViewHost>(details).ptr();
@@ skipping 180 matching lines @@
           CreateBackgroundHostsForProfileStartup(GetProfile(),
                                                  this, service->extensions());
       }
       break;
     }
     default:
       ExtensionProcessManager::Observe(type, source, details);
       break;
   }
 }