Issue 1122593004: firstRectForCharacterRange(): don't fall over in an editable-less frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1122593004: firstRectForCharacterRange(): don't fall over in an editable-less frame. (Closed)

Created:
5 years, 7 months ago by sof

Modified:
5 years, 7 months ago

Reviewers:
haraken, yosin_UTC9, Yuta Kitamura

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

firstRectForCharacterRange(): don't fall over in an editable-less frame. Have this test-only method gracefully handle the case where it is attempted used in a document having no editable element. R=haraken BUG=483639 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194870

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -1 line)			Patch
A	LayoutTests/editing/input/text-input-controller-no-editable-no-crash.html	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	LayoutTests/editing/input/text-input-controller-no-editable-no-crash-expected.txt	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

Please take a look (but only when you're back.) A low priority fix to non-production ...

5 years, 7 months ago (2015-05-04 14:33:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122593004/1

5 years, 7 months ago (2015-05-04 15:05:36 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-04 16:02:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194870

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages