Support SKIA_OUT on Mac and ChromeOS

Support SKIA_OUT on Mac and ChromeOS

BUG=skia:3774
Committed: https://skia.googlesource.com/skia/+/f15132fdcf5aabb874f1c151a872efe54ee95118

[borenet, 2015-05-04 13:46:26]

borenet@google.com changed reviewers:
+ djsollen@google.com

[borenet, 2015-05-04 13:46:27]

https://codereview.chromium.org/1122593003/diff/1/gyp_skia
File gyp_skia (left):

https://codereview.chromium.org/1122593003/diff/1/gyp_skia#oldcode74
gyp_skia:74: print 'ERROR: variable SKIA_OUT is not valid on Mac (using
xcodebuild)'
This actually does work, probably due to our use of ninja instead of xcodebuild
directly.

https://codereview.chromium.org/1122593003/diff/1/platform_tools/chromeos/bin...
File platform_tools/chromeos/bin/chromeos_setup.sh (right):

https://codereview.chromium.org/1122593003/diff/1/platform_tools/chromeos/bin...
platform_tools/chromeos/bin/chromeos_setup.sh:57: exportVar SKIA_OUT
"${SKIA_OUT}/config/chromeos-${TARGET_DEVICE}"
I haven't been able to verify this locally due to GS permissions.

[djsollen, 2015-05-04 14:03:44]

https://codereview.chromium.org/1122593003/diff/1/gyp_skia
File gyp_skia (left):

https://codereview.chromium.org/1122593003/diff/1/gyp_skia#oldcode74
gyp_skia:74: print 'ERROR: variable SKIA_OUT is not valid on Mac (using
xcodebuild)'
On 2015/05/04 13:46:27, borenet wrote:
> This actually does work, probably due to our use of ninja instead of
xcodebuild
> directly.

Will this break the workflow of those who use xcode to build on macs?  As far as
I know not everyone uses ninja.

[borenet, 2015-05-04 14:11:57]

On 2015/05/04 14:03:44, djsollen wrote:
> https://codereview.chromium.org/1122593003/diff/1/gyp_skia
> File gyp_skia (left):
> 
> https://codereview.chromium.org/1122593003/diff/1/gyp_skia#oldcode74
> gyp_skia:74: print 'ERROR: variable SKIA_OUT is not valid on Mac (using
> xcodebuild)'
> On 2015/05/04 13:46:27, borenet wrote:
> > This actually does work, probably due to our use of ninja instead of
> xcodebuild
> > directly.
> 
> Will this break the workflow of those who use xcode to build on macs?  As far
as
> I know not everyone uses ninja.

IIRC, if you're using xcodebuild SKIA_OUT ends up just being ignored.  The only
behavior change should be that if you're using Mac and have SKIA_OUT defined,
rather than throwing an error it'll attempt to actually use it.  For xcodebuild
I believe that means continuing to build in the xcodebuild directory.  For
ninja, we'll build in $SKIA_OUT.

[djsollen, 2015-05-04 14:21:35]

lgtm.  If the trybots says it's good then I'm good.

[borenet, 2015-05-04 14:45:24]

On 2015/05/04 14:21:35, djsollen wrote:
> lgtm.  If the trybots says it's good then I'm good.

The bots don't (yet) use SKIA_OUT, so I wouldn't expect to see any difference in
behavior on the trybots.  Set off a Mac trybot anyway.  If it succeeds I'll CQ.

[borenet, 2015-05-04 14:53:28]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-05-04 14:53:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1122593003/1

[commit-bot: I haz the power, 2015-05-04 15:04:33]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f15132fdcf5aabb874f1c151a872efe54ee95118