Backfill some FX String unit tests for == and !=.

core/src/fxcrt/fx_basic_bstring_unittest.cpp

Index: core/src/fxcrt/fx_basic_bstring_unittest.cpp
diff --git a/core/src/fxcrt/fx_basic_bstring_unittest.cpp b/core/src/fxcrt/fx_basic_bstring_unittest.cpp
index 57cfc8047ee2f67fa82f064327acd2e5bf93c521..165746cc704e55636bfff45c8119f2e9bb37b5b2 100644
--- a/core/src/fxcrt/fx_basic_bstring_unittest.cpp
+++ b/core/src/fxcrt/fx_basic_bstring_unittest.cpp
@@ -45,6 +45,114 @@ TEST(fxcrt, ByteStringOperatorLT) {
     EXPECT_FALSE(def < abc);
 }
 
+TEST(fxcrt, ByteStringOperatorEQ) {
+    CFX_ByteString byteString("hello");

[Lei Zhang, 2015/05/01 21:50:38]

Can we name these byte_string and so on?

[Tom Sepez, 2015/05/01 22:58:41]

Done.

+    ASSERT_TRUE(byteString == byteString);
+
+    CFX_ByteString byteStringSame1("hello");
+    ASSERT_TRUE(byteString == byteStringSame1);
+    ASSERT_TRUE(byteStringSame1 == byteString);
+
+    CFX_ByteString byteStringSame2(byteString);
+    ASSERT_TRUE(byteString == byteStringSame2);
+    ASSERT_TRUE(byteStringSame2 == byteString);
+
+    CFX_ByteString byteString1("he");
+    CFX_ByteString byteString2("hellp");
+    CFX_ByteString byteString3("hellod");
+    ASSERT_FALSE(byteString == byteString1);
+    ASSERT_FALSE(byteString == byteString2);
+    ASSERT_FALSE(byteString == byteString3);
+    ASSERT_FALSE(byteString1 == byteString);
+    ASSERT_FALSE(byteString2 == byteString);
+    ASSERT_FALSE(byteString3 == byteString);
+
+    CFX_ByteStringC byteStringCSame1("hello");
+    ASSERT_TRUE(byteString == byteStringCSame1);
+    ASSERT_TRUE(byteStringCSame1 == byteString);
+
+    CFX_ByteStringC byteStringC1("he");
+    CFX_ByteStringC byteStringC2("hellp");
+    CFX_ByteStringC byteStringC3("hellod");
+    ASSERT_FALSE(byteString == byteStringC1);
+    ASSERT_FALSE(byteString == byteStringC2);
+    ASSERT_FALSE(byteString == byteStringC3);
+    ASSERT_FALSE(byteStringC1 == byteString);
+    ASSERT_FALSE(byteStringC2 == byteString);
+    ASSERT_FALSE(byteStringC3 == byteString);
+
+    const char* cStringSame1 = "hello";
+    ASSERT_TRUE(byteString == cStringSame1);
+#if 0
+    // TODO(tsepez): See, you don't want implicit c_str() casting.
+    // This degrades to a pointer comparision, which flunks.
+    ASSERT_TRUE(cStringSame1 == byteString);
+#endif
+
+    const char* cString1 = "he";
+    const char* cString2 = "hellp";
+    const char* cString3 = "hellod";
+    ASSERT_FALSE(byteString == cString1);
+    ASSERT_FALSE(byteString == cString2);
+    ASSERT_FALSE(byteString == cString3);
+    ASSERT_FALSE(cString1 == byteString);
+    ASSERT_FALSE(cString2 == byteString);
+    ASSERT_FALSE(cString3 == byteString);
+}
+
+TEST(fxcrt, ByteStringOperatorNE) {
+    CFX_ByteString byteString("hello");
+    ASSERT_FALSE(byteString != byteString);
+
+    CFX_ByteString byteStringSame1("hello");
+    ASSERT_FALSE(byteString != byteStringSame1);
+    ASSERT_FALSE(byteStringSame1 != byteString);
+
+    CFX_ByteString byteStringSame2(byteString);
+    ASSERT_FALSE(byteString != byteStringSame2);
+    ASSERT_FALSE(byteStringSame2 != byteString);
+
+    CFX_ByteString byteString1("he");
+    CFX_ByteString byteString2("hellp");
+    CFX_ByteString byteString3("hellod");
+    ASSERT_TRUE(byteString != byteString1);
+    ASSERT_TRUE(byteString != byteString2);
+    ASSERT_TRUE(byteString != byteString3);
+    ASSERT_TRUE(byteString1 != byteString);
+    ASSERT_TRUE(byteString2 != byteString);
+    ASSERT_TRUE(byteString3 != byteString);
+
+    CFX_ByteStringC byteStringCSame1("hello");
+    ASSERT_FALSE(byteString != byteStringCSame1);
+    ASSERT_FALSE(byteStringCSame1 != byteString);
+
+    CFX_ByteStringC byteStringC1("he");
+    CFX_ByteStringC byteStringC2("hellp");
+    CFX_ByteStringC byteStringC3("hellod");
+    ASSERT_TRUE(byteString != byteStringC1);
+    ASSERT_TRUE(byteString != byteStringC2);
+    ASSERT_TRUE(byteString != byteStringC3);
+    ASSERT_TRUE(byteStringC1 != byteString);
+    ASSERT_TRUE(byteStringC2 != byteString);
+    ASSERT_TRUE(byteStringC3 != byteString);
+
+    const char* cStringSame1 = "hello";
+    ASSERT_FALSE(byteString != cStringSame1);
+#if 0
+    // See above TODO.
+    ASSERT_FALSE(cStringSame1 != byteString);
+#endif
+    const char* cString1 = "he";
+    const char* cString2 = "hellp";
+    const char* cString3 = "hellod";
+    ASSERT_TRUE(byteString != cString1);
+    ASSERT_TRUE(byteString != cString2);
+    ASSERT_TRUE(byteString != cString3);
+    ASSERT_TRUE(cString1 != byteString);
+    ASSERT_TRUE(cString2 != byteString);
+    ASSERT_TRUE(cString3 != byteString);
+}
+
 TEST(fxcrt, ByteStringCNull) {
   CFX_ByteStringC null_string;
   EXPECT_EQ(null_string.GetPtr(), nullptr);