Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1122553002: Use atk_component_get_extents in ATK 2.12 and higher. (Closed)

Created:
5 years, 7 months ago by k.czech
Modified:
5 years, 7 months ago
Reviewers:
dmazzoni, Adam Goode
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use atk_component_get_extents instead of atk_component_get_position. atk_component_get_position is deprecated since 2.12 BUG=463671 Committed: https://crrev.com/6913c9e026db9028b91b1182dfc11a905f591b09 Cr-Commit-Position: refs/heads/master@{#328339}

Patch Set 1 #

Total comments: 1

Patch Set 2 : No need macros for versioning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/accessibility/platform/ax_platform_node_auralinux.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
k.czech
5 years, 7 months ago (2015-05-01 19:12:42 UTC) #2
dmazzoni
lgtm
5 years, 7 months ago (2015-05-01 20:13:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122553002/1
5 years, 7 months ago (2015-05-01 20:14:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/84533)
5 years, 7 months ago (2015-05-01 20:26:01 UTC) #7
Adam Goode
https://codereview.chromium.org/1122553002/diff/1/ui/accessibility/platform/ax_platform_node_auralinux.cc File ui/accessibility/platform/ax_platform_node_auralinux.cc (right): https://codereview.chromium.org/1122553002/diff/1/ui/accessibility/platform/ax_platform_node_auralinux.cc#newcode194 ui/accessibility/platform/ax_platform_node_auralinux.cc:194: atk_component_get_extents(ATK_COMPONENT(atk_object), Just use atk_component_get_extents. It is present in the ...
5 years, 7 months ago (2015-05-05 01:28:18 UTC) #9
k.czech
On 2015/05/05 01:28:18, Adam Goode wrote: > https://codereview.chromium.org/1122553002/diff/1/ui/accessibility/platform/ax_platform_node_auralinux.cc > File ui/accessibility/platform/ax_platform_node_auralinux.cc (right): > > https://codereview.chromium.org/1122553002/diff/1/ui/accessibility/platform/ax_platform_node_auralinux.cc#newcode194 ...
5 years, 7 months ago (2015-05-05 13:22:23 UTC) #10
k.czech
Dominic, could look at this change again ?
5 years, 7 months ago (2015-05-05 13:54:19 UTC) #11
dmazzoni
lgtm
5 years, 7 months ago (2015-05-05 14:50:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1122553002/20001
5 years, 7 months ago (2015-05-05 14:50:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-05 16:29:40 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 16:30:33 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6913c9e026db9028b91b1182dfc11a905f591b09
Cr-Commit-Position: refs/heads/master@{#328339}

Powered by Google App Engine
This is Rietveld 408576698