Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 112253004: take 2: create simple 'skpmaker' tool to generate SKP files for testing (Closed)

Created:
6 years, 11 months ago by epoger
Modified:
6 years, 11 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

take 2: create simple 'skpmaker' tool to generate SKP files for testing (re-landing https://codereview.chromium.org/108343006 without the build breakages) BUG=skia:1943 Committed: http://code.google.com/p/skia/source/detail?r=12866

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -3 lines) Patch
M gyp/tools.gyp View 2 chunks +18 lines, -3 lines 0 comments Download
A tools/skpmaker.cpp View 1 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
patchset 1 is the change as it was in the original CL (causes warnings on ...
6 years, 11 months ago (2014-01-02 19:14:25 UTC) #1
epoger
Please see the diffs between patchsets 1 and 2, and the different trybot results for ...
6 years, 11 months ago (2014-01-02 19:25:58 UTC) #2
rmistry
LGTM
6 years, 11 months ago (2014-01-02 19:30:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/112253004/40001
6 years, 11 months ago (2014-01-02 19:30:53 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-02 19:42:17 UTC) #5
Message was sent while issue was closed.
Change committed as 12866

Powered by Google App Engine
This is Rietveld 408576698