Initial JS stub implementation of Object.observe. Adds support for .object/.unobserve/.notify/.deli…

test/mjsunit/harmony/object-observe.js

Index: test/mjsunit/harmony/object-observe.js
diff --git a/test/mjsunit/harmony/object-observe.js b/test/mjsunit/harmony/object-observe.js
new file mode 100644
index 0000000000000000000000000000000000000000..037d4e41a4b4b454b7666468c16d686ebe4e4379
--- /dev/null
+++ b/test/mjsunit/harmony/object-observe.js
@@ -0,0 +1,116 @@
+// Copyright 2012 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//     * Redistributions of source code must retain the above copyright
+//       notice, this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above
+//       copyright notice, this list of conditions and the following
+//       disclaimer in the documentation and/or other materials provided
+//       with the distribution.
+//     * Neither the name of Google Inc. nor the names of its
+//       contributors may be used to endorse or promote products derived
+//       from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Copyright 2011 the V8 project authors. All rights reserved.

[adamk, 2012/10/23 16:29:44]

Woops, duplicated license

[rafaelw, 2012/10/23 21:21:35]

Done.

+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//     * Redistributions of source code must retain the above copyright
+//       notice, this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above
+//       copyright notice, this list of conditions and the following
+//       disclaimer in the documentation and/or other materials provided
+//       with the distribution.
+//     * Neither the name of Google Inc. nor the names of its
+//       contributors may be used to endorse or promote products derived
+//       from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Flags: --harmony-object-observe
+
+(function() {
+  var obj = {};
+  var records;
+  var callbackCount = 0;
+  function obs(r) {
+    callbackCount++;
+    records = r;
+  }
+
+  function frozenFunction() {}
+  Object.freeze(frozenFunction);
+  var nonFunction = {};
+
+  // Object.observe
+  assertThrows(function() { Object.observe("non-object", obs); }, TypeError);
+  assertThrows(function() { Object.observe(obj, nonFunction); }, TypeError);
+  assertThrows(function() { Object.observe(obj, frozenFunction); }, TypeError);
+
+  // Object.unobserve

[adamk, 2012/10/23 16:29:44]

Seems like a test for unobserve's functionality would be good too.

[rafaelw, 2012/10/23 21:21:35]

Done.

+  assertThrows(function() { Object.unobserve(4, obs); }, TypeError);
+
+  // Object.notify
+  assertThrows(function() { Object.notify(obs, {}); }, TypeError);
+  assertThrows(function() { Object.notify(obs, { type: 4 }); }, TypeError);
+
+  // Object.deliverChangeRecords
+  assertThrows(function() { Object.deliverChangeRecords(nonFunction); }, TypeError);
+
+  Object.observe(obj, obs);
+  Object.notify(obj, {
+    object: obj,
+    type: 'updated',
+    name: 'foo',
+    expando: 1
+  });
+
+  Object.notify(obj, {
+    object: obj,
+    type: 'deleted',
+    name: 'bar',
+    expando2: 'str'
+  });
+  Object.deliverChangeRecords(obs);
+  assertEquals(1, callbackCount);
+  assertEquals(2, records.length);
+  assertEquals(obj, records[0].object);
+  assertEquals('foo', records[0].name);
+  assertEquals('updated', records[0].type);
+  assertEquals(1, records[0].expando);
+  assertEquals(obj, records[1].object);
+  assertEquals('bar', records[1].name);
+  assertEquals('deleted', records[1].type);
+  assertEquals('str', records[1].expando2);
+  assertEquals(undefined, records[1].expando);
+
+  records = undefined;
+  Object.deliverChangeRecords(obs);
+  assertEquals(1, callbackCount);
+  assertEquals(undefined, records);
+})()