Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: src/messages.js

Issue 11225058: Initial JS stub implementation of Object.observe. Adds support for .object/.unobserve/.notify/.deli… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: install functions on Object, not Object.prototype Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/messages.js
diff --git a/src/messages.js b/src/messages.js
index fe894b578fdb0833151a1709ae348225deec50bb..7d0c6bda42f1931e01c787959395caf64cae3b50 100644
--- a/src/messages.js
+++ b/src/messages.js
@@ -203,6 +203,10 @@ function FormatMessage(message) {
"proxy_repeated_prop_name", ["Trap '", "%1", "' returned repeated property name '", "%2", "'"],
"invalid_weakmap_key", ["Invalid value used as weak map key"],
"not_date_object", ["this is not a Date object."],
+ "observe_non_object", ["Object.", "%0", " cannot ", "%0", " non-object"],
arv (Not doing code reviews) 2012/10/25 20:43:44 Should this be "Object " instead of "Object.". Sam
rafaelw 2012/10/26 05:34:14 This gets concat with the %0 value, e.g "Object.ob
+ "observe_non_function", ["Object.", "%0", " cannot deliver to non-function"],
+ "observe_callback_frozen", ["Object.observe cannot deliver to a frozen function object"],
+ "observe_type_non_string", ["Object.notify provided changeRecord with non-string 'type' property"],
// RangeError
"invalid_array_length", ["Invalid array length"],
"stack_overflow", ["Maximum call stack size exceeded"],
« no previous file with comments | « src/flag-definitions.h ('k') | src/object-observe.js » ('j') | src/object-observe.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698