Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: utils/pub/hosted_source.dart

Issue 11225056: Remove second sleep in pub and enable pub tests on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | utils/tests/pub/pub.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/hosted_source.dart
diff --git a/utils/pub/hosted_source.dart b/utils/pub/hosted_source.dart
index 47cda674778c724c0b86b11c5bc2b637948e8d04..eb4b86fd79013c09f817ab113253d19c9189b532 100644
--- a/utils/pub/hosted_source.dart
+++ b/utils/pub/hosted_source.dart
@@ -86,16 +86,7 @@ class HostedSource extends Source {
// Now that the install has succeeded, move it to the real location in
// the cache. This ensures that we don't leave half-busted ghost
// directories in the user's pub cache if an install fails.
-
- if (io.Platform.operatingSystem == "windows") {
- // TODO(rnystrom): Awful hack. On Windows, we see cases where the
- // extract has not finished by the time we get here, so the rename fails
- // with a "directory in use" error. So, we will just wait a couple of
- // seconds before we start.
- return sleep(2000).chain((_) => renameDir(tempDir, destPath));
- } else {
- return renameDir(tempDir, destPath);
- }
+ return renameDir(tempDir, destPath);
}).transform((_) => true);
}
« no previous file with comments | « no previous file | utils/tests/pub/pub.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698