Cache more information when launching NaCl sel_ldr, and pass 'Dev' interface

Cache more information when launching NaCl sel_ldr, and pass 'Dev' interface
permission bit to proxy.
BUG=116317
TEST=manual
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163691

[bbudge, 2012-10-23 00:46:46]

Yuzhu  for ppb_nacl_private_impl.cc
Brett for the rest (should be easy) and OWNERS

[brettw, 2012-10-23 05:19:48]

LGTM with important fix, I didn't look at ppb_nacl_private_impl.cc

http://codereview.chromium.org/11225051/diff/8001/chrome/browser/nacl_host/na...
File chrome/browser/nacl_host/nacl_process_host.cc (right):

http://codereview.chromium.org/11225051/diff/8001/chrome/browser/nacl_host/na...
chrome/browser/nacl_host/nacl_process_host.cc:647: channel_handle,
process_->GetData().handle);
I think you mean "id" instead of "handle". The handle won't be valid in the
renderer.

[bbudge, 2012-10-23 17:20:10]

Adding David for ppb_nacl_private_impl.cc

http://codereview.chromium.org/11225051/diff/8001/chrome/browser/nacl_host/na...
File chrome/browser/nacl_host/nacl_process_host.cc (right):

http://codereview.chromium.org/11225051/diff/8001/chrome/browser/nacl_host/na...
chrome/browser/nacl_host/nacl_process_host.cc:647: channel_handle,
process_->GetData().handle);
On 2012/10/23 05:19:48, brettw wrote:
> I think you mean "id" instead of "handle". The handle won't be valid in the
> renderer.

Yes. This won't even compile on Windows. Done.

[dmichael (off chromium), 2012-10-23 19:05:30]

ppb_nacl_private_impl.cc lgtm, modulo nit

https://chromiumcodereview.appspot.com/11225051/diff/1010/chrome/renderer/pep...
File chrome/renderer/pepper/ppb_nacl_private_impl.cc (right):

https://chromiumcodereview.appspot.com/11225051/diff/1010/chrome/renderer/pep...
chrome/renderer/pepper/ppb_nacl_private_impl.cc:42: IPC::ChannelHandle
channel_handle;
How about a default constructor to make sure plugin_child_id is initialized?

https://chromiumcodereview.appspot.com/11225051/diff/1010/chrome/renderer/pep...
chrome/renderer/pepper/ppb_nacl_private_impl.cc:112: allow_dev_interfaces ?
ppapi::PERMISSION_DEV : 0);
Just curious, how do we handle white-listed Private interfaces, like UDP/TCP? It
doesn't use PpapiPermissions?

[bbudge, 2012-10-23 19:53:03]

http://codereview.chromium.org/11225051/diff/1010/chrome/renderer/pepper/ppb_...
File chrome/renderer/pepper/ppb_nacl_private_impl.cc (right):

http://codereview.chromium.org/11225051/diff/1010/chrome/renderer/pepper/ppb_...
chrome/renderer/pepper/ppb_nacl_private_impl.cc:42: IPC::ChannelHandle
channel_handle;
On 2012/10/23 19:05:30, dmichael wrote:
> How about a default constructor to make sure plugin_child_id is initialized?

Done.

http://codereview.chromium.org/11225051/diff/1010/chrome/renderer/pepper/ppb_...
chrome/renderer/pepper/ppb_nacl_private_impl.cc:112: allow_dev_interfaces ?
ppapi::PERMISSION_DEV : 0);
On 2012/10/23 19:05:30, dmichael wrote:
> Just curious, how do we handle white-listed Private interfaces, like UDP/TCP?
It
> doesn't use PpapiPermissions?

Right now, the plugin side returns NULL for 'Private' interfaces. On the browser
side, which is where the real restriction must happen, I don't think we restrict
these yet.

[commit-bot: I haz the power, 2012-10-23 19:57:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/11225051/4003

[commit-bot: I haz the power, 2012-10-23 19:57:41]

Presubmit check for 11225051-4003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
Missing PPAPI IDL for private interface, please generate IDL:

***************
  ppapi/c/private/ppb_nacl_private.h
***************

Presubmit checks took 2.5s to calculate.