Issue 11225037: [NaCl SDK] move VSNaClSDKRoot into ConfigurationGeneral section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11225037: [NaCl SDK] move VSNaClSDKRoot into ConfigurationGeneral section (Closed)

Created:
8 years, 2 months ago by Sam Clegg

Modified:
8 years, 2 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] move VSNaClSDKRoot into ConfigurationGeneral section This change removes a lot of the hacking we were previously doing to make sure that the value of VSNaClSDKRoot was available in all the right place. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1457

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -84 lines)			Patch
M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Props/nacl_general.xml	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/Props/ppapi_general.xml.patch	View		4 chunks	+5 lines, -8 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj	View		3 chunks	+7 lines, -26 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs	View		1 chunk	+0 lines, -44 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs	View	1	1 chunk	+33 lines, -0 lines	1 comment	Download
M	visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs	View	1	2 chunks	+9 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

binji

8 years, 2 months ago (2012-10-23 00:59:31 UTC) #4

nice test! slgtm

http://codereview.chromium.org/11225037/diff/3001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs (right):

http://codereview.chromium.org/11225037/diff/3001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs:215:
TestUtilities.AssertPropertyContains(debug_, page, "IncludePath",
@"foo\include;", true, true);
nit: wrap all of these at 100 chars

http://codereview.chromium.org/11225037/diff/3001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs (right):

http://codereview.chromium.org/11225037/diff/3001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs:331: bool
expand=false)
add param to docs above

Expand Messages | Collapse Messages