runtime/vm/service/vmservice.dart - Issue 1122503003: Display isolate message queue in Observatory debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service/vmservice.dart

Issue 1122503003: Display isolate message queue in Observatory debugger (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/service/vmservice.dart

diff --git a/runtime/vm/service/vmservice.dart b/runtime/vm/service/vmservice.dart

index a627ed740fe13fd62d80d9ec25cf4f0d217bdd8c..2a6bbc2879ac870eda2bee4e19bc7456426b069f 100644

--- a/runtime/vm/service/vmservice.dart

+++ b/runtime/vm/service/vmservice.dart

@@ -68,7 +68,9 @@ class VMService extends MessageRouter {

void _exit() {

isolateLifecyclePort.close();

scriptLoadPort.close();

- for (var client in clients) {

+ // Create a copy of the set as a list because client.close() alters the set.

+ var clientsList = clients.toList();

+ for (var client in clientsList) {

client.close();

}

// Call embedder shutdown hook after the internal shutdown.

« no previous file with comments | « runtime/vm/service.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »