Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1122503003: Display isolate message queue in Observatory debugger (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 27835474194afbb9b38ca5728ceaf8d18b4af163..44d7d6552536c9824a55b2c6bbb7e5e88596f22a 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -79,6 +79,7 @@ abstract class ServiceObject extends Observable {
bool get isNull => type == 'null';
bool get isSentinel => type == 'Sentinel';
bool get isString => type == 'String';
+ bool get isMessage => type == 'Message';
// Kinds of Instance.
bool get isMirrorReference => vmType == 'MirrorReference';
@@ -2209,6 +2210,7 @@ class Script extends ServiceObject with Coverage {
if (mapIsRef) {
return;
}
+ _loaded = true;
lineOffset = map['lineOffset'];
columnOffset = map['columnOffset'];
_parseTokenPosTable(map['tokenPosTable']);
@@ -2282,8 +2284,6 @@ class Script extends ServiceObject with Coverage {
}
void _processSource(String source) {
- // Preemptyively mark that this is not loaded.
- _loaded = false;
if (source == null) {
return;
}
@@ -2291,8 +2291,6 @@ class Script extends ServiceObject with Coverage {
if (sourceLines.length == 0) {
return;
}
- // We have the source to the script. This is now loaded.
- _loaded = true;
lines.clear();
Logger.root.info('Adding ${sourceLines.length} source lines for ${_url}');
for (var i = 0; i < sourceLines.length; i++) {
« no previous file with comments | « runtime/observatory/lib/src/elements/script_ref.dart ('k') | runtime/observatory/tests/service/get_stack_rpc_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698